Skip to content

[5.2] Fix | Fix issue with Socket.Connect in managed SNI (#2777)#2779

Merged
JRahnama merged 1 commit into
dotnet:release/5.2from
JRahnama:backport-socket-issue-to-5-2
Aug 15, 2024
Merged

[5.2] Fix | Fix issue with Socket.Connect in managed SNI (#2777)#2779
JRahnama merged 1 commit into
dotnet:release/5.2from
JRahnama:backport-socket-issue-to-5-2

Conversation

@JRahnama

@JRahnama JRahnama commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

Ports #2777

@JRahnama JRahnama added Area\Managed SNI Issues that are targeted to the Managed SNI codebase. Regression 💥 Issues that are regressions introduced from earlier PRs. labels Aug 15, 2024
@JRahnama
JRahnama merged commit a1672c3 into dotnet:release/5.2 Aug 15, 2024
@JRahnama
JRahnama deleted the backport-socket-issue-to-5-2 branch August 15, 2024 23:13
@codecov

codecov Bot commented Aug 15, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.62%. Comparing base (ec5ad66) to head (4b9a0e2).
Report is 2 commits behind head on release/5.2.

Files Patch % Lines
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 57.14% 3 Missing ⚠️
...core/src/Microsoft/Data/SqlClient/SNI/SNICommon.cs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/5.2    #2779      +/-   ##
===============================================
- Coverage        72.64%   72.62%   -0.02%     
===============================================
  Files              310      310              
  Lines            61881    61930      +49     
===============================================
+ Hits             44953    44977      +24     
- Misses           16928    16953      +25     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.79% <63.63%> (-0.04%) ⬇️
netfx 70.23% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Managed SNI Issues that are targeted to the Managed SNI codebase. Regression 💥 Issues that are regressions introduced from earlier PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants