Skip to content

Introduce Logging package and rework official pipelines #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulmedynski merged 64 commits into from
Feb 24, 2026
Merged

Introduce Logging package and rework official pipelines #3967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
88b5e91
Initialize Logging package
cheenamalhotra Feb 17, 2026
ed287b5
Update Event Scope type names
cheenamalhotra Feb 18, 2026
f49e21a
Include Logging in package ref
cheenamalhotra Feb 18, 2026
9a412a8
Cleanup pipelines, add non-official as well
cheenamalhotra Feb 18, 2026
c629a27
Include SNK signing key
cheenamalhotra Feb 18, 2026
8aba060
Rename pipeline
cheenamalhotra Feb 18, 2026
8c14916
Fix keywords
cheenamalhotra Feb 18, 2026
4ae5f15
Fix pipelines to not release if no release job is selected
cheenamalhotra Feb 18, 2026
8b4ab2e
Notification based release stage + fix build number format
cheenamalhotra Feb 18, 2026
991e2af
Conditional execution
cheenamalhotra Feb 18, 2026
2a20bcd
Add back the revision number decimal
cheenamalhotra Feb 18, 2026
f1a52b6
Update ESRP version + split build number
cheenamalhotra Feb 18, 2026
a5518e6
Fix the build job to build and pack separately (as we need to pack si…
cheenamalhotra Feb 18, 2026
7c651a4
Fix for APIScan failure, ensure DLLs are copied first.
cheenamalhotra Feb 18, 2026
2f60302
Include readme files in NuGet packages
cheenamalhotra Feb 18, 2026
0a19676
Fix APIScan issue
cheenamalhotra Feb 18, 2026
69b55b5
Fix build error and APIScan errors
cheenamalhotra Feb 18, 2026
8c3a2b0
download packages before building dependent packages
cheenamalhotra Feb 18, 2026
f95382a
Fix azure project build by providing abstractions package version
cheenamalhotra Feb 18, 2026
e86f3f1
Rename file to Readme in all packages
cheenamalhotra Feb 18, 2026
0507f98
Enable APIScan and include instructions for onebranch pipelines.
cheenamalhotra Feb 18, 2026
eecfc11
Pass effective logging package version to AKV build
cheenamalhotra Feb 19, 2026
71fa038
Fix
cheenamalhotra Feb 19, 2026
8fc0ec4
Include ob_outputDirectory variable, and other fixes
cheenamalhotra Feb 19, 2026
95a1e5b
Implement approval service
cheenamalhotra Feb 19, 2026
24b64f7
Configure ob_release params for approval service
cheenamalhotra Feb 19, 2026
c3f9d85
Skip building packages when not requested.
cheenamalhotra Feb 19, 2026
648a3e6
Split environments (prod v/s non-prod)
cheenamalhotra Feb 19, 2026
2f7a410
Touch-ups to job names
cheenamalhotra Feb 19, 2026
2cedac3
Fix release stage to be deployment job
cheenamalhotra Feb 19, 2026
ff1008e
Update release job
cheenamalhotra Feb 19, 2026
aec1744
Remove conditions
cheenamalhotra Feb 19, 2026
77eab21
More fixes
cheenamalhotra Feb 19, 2026
5d9ee17
Update release category
cheenamalhotra Feb 19, 2026
01b74ff
Fix dependencies on build stages
cheenamalhotra Feb 19, 2026
7138ef6
temporarily disabling breaking on APIScan errors in non-official builds
cheenamalhotra Feb 19, 2026
10cc2ea
Update pipelines to depend on package validation before release
cheenamalhotra Feb 19, 2026
f65d7a8
Updated sequence diagram
cheenamalhotra Feb 19, 2026
c569d8a
Add missing version
cheenamalhotra Feb 19, 2026
b19a67a
Add missing property
cheenamalhotra Feb 19, 2026
c3a2bb5
Fix ESRP signing parameter casing in build-akv-official-job.yml (#3968)
Copilot Feb 19, 2026
ed24f1f
Use effective version of MDS for AKV provider job
cheenamalhotra Feb 19, 2026
a31b287
Version Updates, fixes
cheenamalhotra Feb 19, 2026
ae4e876
Update eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml
cheenamalhotra Feb 19, 2026
ec31d8d
Update CI Build variables
cheenamalhotra Feb 20, 2026
646e00b
Fix CI pipelines and remove unwanted pipeline
cheenamalhotra Feb 20, 2026
d2498bd
Use build number as is
cheenamalhotra Feb 20, 2026
cf4c99f
Addressed a bunch of my comments in the PR.
paulmedynski Feb 20, 2026
7129067
Further changes related to PR comments.
paulmedynski Feb 20, 2026
a8f5bb2
Fixed missing assemblyBuildNumber argument.
paulmedynski Feb 20, 2026
6e02918
Fixed another missing assemblyBuildNumber.
paulmedynski Feb 20, 2026
569c902
Fixed expression variable expansion of build number.
paulmedynski Feb 20, 2026
3f35416
Fixed reflection bug in the tests.
paulmedynski Feb 20, 2026
cbaf0f6
Fixed stage name typo.
paulmedynski Feb 20, 2026
e475f86
- Removed redundant SqlServer package templates.
paulmedynski Feb 20, 2026
c3b9941
- Removed special build/pack setup for SqlServer package.
paulmedynski Feb 22, 2026
7016397
Lots of changes related to PR comments.
paulmedynski Feb 23, 2026
925e438
- Fixing dotnet pack tasks.
paulmedynski Feb 23, 2026
b5232d3
- Added symbols publishing to packages using the common jobs.
paulmedynski Feb 23, 2026
2c35310
- Factored out the common parts of the OneBranch pipelines.
paulmedynski Feb 23, 2026
f9b4c1c
- Fixed typo in ApiScan variables.
paulmedynski Feb 24, 2026
30e7e71
Fixed strong name signing to occur on all OneBranch pipelines.
paulmedynski Feb 24, 2026
f4de530
Fixed InternalsVisibleTo for signed builds.
paulmedynski Feb 24, 2026
e85687c
Merge branch 'main' into dev/cheena/logging-package
paulmedynski Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Touch-ups to job names
  • Loading branch information
@cheenamalhotra
cheenamalhotra committed Feb 19, 2026
commit 2f7a410c2ec3188f2dbf7c2b577a3626740efe26
2 changes: 1 addition & 1 deletion eng/pipelines/common/templates/jobs/build-signed-package-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ parameters:

jobs:
- job: build_signed_package
displayName: 'Build Signed MDS Package'
displayName: 'Build Microsoft.Data.SqlClient'
pool:
type: windows # read more about custom job pool types at https://aka.ms/obpipelines/yaml/jobs

Expand Down
12 changes: 6 additions & 6 deletions eng/pipelines/dotnet-sqlclient-non-official-pipeline.yml
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@paulmedynski paulmedynski Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These top-level pipeline files should be renamed to match the Azure DevOps pipeline names sqlclient-official and sqlclient-non-official.

Copy link
Copy Markdown
Contributor

@paulmedynski paulmedynski Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is almost identical to the official pipeline. We should abstract most of it away to avoid duplication, especially for the fiddly OneBranch config.

Original file line number Diff line number Diff line change
Expand Up @@ -340,47 +340,47 @@ extends:
- ${{ if eq(parameters.releaseSqlServerServer, true) }}:
- template: /eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml@self
parameters:
packageDisplayName: SqlServer.Server
packageDisplayName: Microsoft.SqlServer.Server
artifactName: drop_build_independent_build_signed_sqlserver_package
nugetServiceConnection: $(NuGetServiceConnection)
dryRun: true

- ${{ if eq(parameters.releaseLogging, true) }}:
- template: /eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml@self
parameters:
packageDisplayName: Logging
packageDisplayName: Microsoft.Data.SqlClient.Extensions.Logging
artifactName: drop_build_independent_build_signed_Logging_package
nugetServiceConnection: $(NuGetServiceConnection)
dryRun: true

- ${{ if eq(parameters.releaseAbstractions, true) }}:
- template: /eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml@self
parameters:
packageDisplayName: Abstractions
packageDisplayName: Microsoft.Data.SqlClient.Extensions.Abstractions
artifactName: drop_build_independent_build_signed_Abstractions_package
nugetServiceConnection: $(NuGetServiceConnection)
dryRun: true

- ${{ if eq(parameters.releaseSqlClient, true) }}:
- template: /eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml@self
parameters:
packageDisplayName: SqlClient
packageDisplayName: Microsoft.Data.SqlClient
artifactName: drop_buildMDS_build_signed_package
nugetServiceConnection: $(NuGetServiceConnection)
dryRun: true

- ${{ if eq(parameters.releaseExtAzure, true) }}:
- template: /eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml@self
parameters:
packageDisplayName: Extensions.Azure
packageDisplayName: Microsoft.Data.SqlClient.Extensions.Azure
artifactName: drop_buildMDS_build_signed_Azure_package
nugetServiceConnection: $(NuGetServiceConnection)
dryRun: true

- ${{ if eq(parameters.releaseAKVProvider, true) }}:
- template: /eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml@self
parameters:
packageDisplayName: AKVProvider
packageDisplayName: Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider
artifactName: drop_build_addons_buildSignedAkvPackage
nugetServiceConnection: $(NuGetServiceConnection)
dryRun: true
12 changes: 6 additions & 6 deletions eng/pipelines/dotnet-sqlclient-official-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,47 +382,47 @@ extends:
- ${{ if eq(parameters.releaseSqlServerServer, true) }}:
- template: /eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml@self
parameters:
packageDisplayName: SqlServer.Server
packageDisplayName: Microsoft.SqlServer.Server
artifactName: drop_build_independent_build_signed_sqlserver_package
nugetServiceConnection: $(NuGetServiceConnection)
dryRun: ${{ parameters.releaseDryRun }}

- ${{ if eq(parameters.releaseLogging, true) }}:
- template: /eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml@self
parameters:
packageDisplayName: Logging
packageDisplayName: Microsoft.Data.SqlClient.Extensions.Logging
artifactName: drop_build_independent_build_signed_Logging_package
nugetServiceConnection: $(NuGetServiceConnection)
dryRun: ${{ parameters.releaseDryRun }}

- ${{ if eq(parameters.releaseAbstractions, true) }}:
- template: /eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml@self
parameters:
packageDisplayName: Abstractions
packageDisplayName: Microsoft.Data.SqlClient.Extensions.Abstractions
artifactName: drop_build_independent_build_signed_Abstractions_package
nugetServiceConnection: $(NuGetServiceConnection)
dryRun: ${{ parameters.releaseDryRun }}

- ${{ if eq(parameters.releaseSqlClient, true) }}:
- template: /eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml@self
parameters:
packageDisplayName: SqlClient
packageDisplayName: Microsoft.Data.SqlClient
artifactName: drop_buildMDS_build_signed_package
nugetServiceConnection: $(NuGetServiceConnection)
dryRun: ${{ parameters.releaseDryRun }}

- ${{ if eq(parameters.releaseExtAzure, true) }}:
- template: /eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml@self
parameters:
packageDisplayName: Extensions.Azure
packageDisplayName: Microsoft.Data.SqlClient.Extensions.Azure
artifactName: drop_buildMDS_build_signed_Azure_package
nugetServiceConnection: $(NuGetServiceConnection)
dryRun: ${{ parameters.releaseDryRun }}

- ${{ if eq(parameters.releaseAKVProvider, true) }}:
- template: /eng/pipelines/common/templates/jobs/publish-nuget-package-job.yml@self
parameters:
packageDisplayName: AKVProvider
packageDisplayName: Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider
artifactName: drop_build_addons_buildSignedAkvPackage
nugetServiceConnection: $(NuGetServiceConnection)
dryRun: ${{ parameters.releaseDryRun }}
2 changes: 1 addition & 1 deletion eng/pipelines/jobs/build-akv-official-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ parameters:

jobs:
- job: buildSignedAkvPackage
displayName: 'Build Signed AKV Package'
displayName: 'Build Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider'
pool:
type: windows

Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/jobs/build-signed-csproj-package-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ parameters:

jobs:
- job: build_signed_${{ replace(parameters.buildTarget, 'Build', '') }}_package
displayName: 'Build Signed ${{ parameters.packageDisplayName }} Package'
displayName: 'Build ${{ parameters.softwareName }}'
pool:
type: windows

Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/jobs/build-signed-sqlserver-package-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ parameters:

jobs:
- job: build_signed_sqlserver_package
displayName: 'Build and Sign Microsoft.SqlServer.Server'
displayName: 'Build Microsoft.SqlServer.Server'
pool:
type: windows

Expand Down