Remove extra connection options parameters

[mdaigle]

This pull request refactors the connection management code to simplify method signatures and remove the use of the SqlConnectionOptions userOptions parameter from internal APIs and connection pool implementations. The main goal is to streamline the process of opening and replacing connections, making the codebase easier to maintain and less error-prone.

Connection Management API Simplification:

• Removed the SqlConnectionOptions userOptions parameter from the signatures of TryOpenConnection, TryReplaceConnection, and related methods in DbConnectionInternal, DbConnectionClosed, and SqlConnectionInternal. All internal logic and calls have been updated accordingly. [1] [2] [3] [4] [5]
• Updated the implementation of TryOpenConnectionInternal and its callers to no longer require or pass userOptions. [1] [2]

Connection Pool Interface and Implementation Updates:

• Simplified the IDbConnectionPool interface by removing the userOptions parameter from TryGetConnection and ReplaceConnection, and updated all implementing classes (ChannelDbConnectionPool, WaitHandleDbConnectionPool) to match the new signatures. [1] [2] [3] [4] [5] [6]
• Refactored all usages of connection pool methods to remove the now-unnecessary userOptions argument, including internal helper methods such as OpenNewInternalConnection and GetInternalConnection. [1] [2] [3] [4] [5]

Code Clean-up and Comments:

• Removed obsolete comments and code related to userConnectionOptions, including .NET Framework-specific permission demand logic that is no longer relevant. [1] [2] [3]

New tests for CAS Functionality

• Added tests to verify that the appropriate permissions are demanded when opening a connection. CAS is a deprecated feature, but we maintain it for backwards compatibility.

These changes collectively modernize and clarify the connection handling logic, reducing unnecessary complexity and improving maintainability.

[Copilot]

Pull request overview

This pull request simplifies SqlClient’s internal connection-opening and pooling pathways by removing the redundant SqlConnectionOptions userOptions parameter from multiple internal methods/constructors, aligning call chains across pooled/non-pooled and sync/async flows.

Changes:

• Removed userOptions from internal open/replace/get-connection APIs (DbConnectionInternal/DbConnectionClosed/SqlConnectionInternal → SqlConnectionFactory → IDbConnectionPool implementations).
• Updated IDbConnectionPool and both pool implementations (wait-handle + channel-based) to the new signatures.
• Updated unit tests to use the simplified pool API surface.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/Microsoft.Data.SqlClient/tests/UnitTests/ConnectionPool/WaitHandleDbConnectionPoolTransactionTest.cs	Updates unit tests to call pool APIs without SqlConnectionOptions.
src/Microsoft.Data.SqlClient/tests/UnitTests/ConnectionPool/TransactedConnectionPoolTest.cs	Updates mock IDbConnectionPool implementation signatures to match interface changes.
src/Microsoft.Data.SqlClient/tests/UnitTests/ConnectionPool/ChannelDbConnectionPoolTest.cs	Updates tests to remove SqlConnectionOptions arguments from pool calls.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionFactory.cs	Removes userOptions threading through connection creation/open paths and pool calls.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs	Updates open logic to call TryOpenConnection/TryReplaceConnection without UserConnectionOptions.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs	Removes userOptions from pending/open/create APIs and replaces usages with simplified calls.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/IDbConnectionPool.cs	Simplifies interface by removing userOptions from TryGetConnection and ReplaceConnection.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs	Updates interface implementation and removes userOptions plumbing from internal open logic.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Connection/SqlConnectionInternal.cs	Removes optional userConnectionOptions parameter and associated NETFRAMEWORK permission-demand block.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbConnectionInternal.cs	Updates internal open pipeline to no longer pass userOptions into factory/pool methods.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbConnectionClosed.cs	Updates closed-state open/replace paths to match the simplified method signatures.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

[codecov]

Codecov Report

❌ Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.56%. Comparing base (be95ca2) to head (be09e9a).

Files with missing lines	Patch %	Lines
.../Microsoft/Data/ProviderBase/DbConnectionClosed.cs	33.33%	2 Missing ⚠️
...icrosoft/Data/ProviderBase/DbConnectionInternal.cs	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4261      +/-   ##
==========================================
- Coverage   65.96%   64.56%   -1.41%     
==========================================
  Files         275      270       -5     
  Lines       42993    65777   +22784     
==========================================
+ Hits        28361    42468   +14107     
- Misses      14632    23309    +8677     

Flag	Coverage Δ
CI-SqlClient	?
PR-SqlClient-Project	64.56% <87.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.