Introduce new performance benchmark runners by cheenamalhotra · Pull Request #4447 · dotnet/SqlClient

cheenamalhotra · 2026-07-15T07:14:38Z

Summary

Adds 8 BenchmarkDotNet runners to Microsoft.Data.SqlClient.PerformanceTests covering previously-reported hot spots, plus config/wiring updates to support them.

New runners

Runner	Purpose	Issues
AsyncLargeDataReadRunner.cs	Sync vs async reads of large `VARBINARY(MAX)` (1–20 MB)	#593, #1562
MarsOverheadRunner.cs	Query execution with MARS on/off	#422, #1283
ParallelAsyncConnectionRunner.cs	Concurrent `OpenAsync` (10/50/100), pooling on/off	#601, #979
CancellationTokenReadAsyncRunner.cs	`CancellationToken` overhead in `ReadAsync`	#2408
SequentialXmlReadRunner.cs	`SequentialAccess` XML reads at increasing sizes (O(N²) check)	#1877
JsonVsVarcharReadRunner.cs	`JSON` vs `VARCHAR(MAX)` reads (disabled by default, needs SQL 2025+)	#3499
BeginTransactionRunner.cs	`BeginTransaction`/`Async` latency vs baseline	#1554
ConnectionPoolStressRunner.cs	Pool stress: churn, random hold, mixed sync/async, reuse, exhaustion/recovery (Parallelism {10,20,25} × MaxPoolSize {50,100})	#601, #979, #3356

Supporting changes

Program.cs — registers new runners, gated by RunnerJob.Enabled
Config/Config.cs — new config fields + RunnerJob per runner
Config/BenchmarkConfig.cs — DontOverwriteResults, JoinSummary, COMPlus_gcServer=1
runnerconfig.jsonc — entries added for new runners (JSON runner off by default), and new configuration options.

Validation

Ran all new runners locally (.NET 9.0 Release, Apple M3 Pro, Docker azure-sql-edge) — all completed successfully.

Checklist

Tests added (perf runners)
No public API changes
Verified against SQL Server
No breaking changes

Copilot

Pull request overview

Adds new BenchmarkDotNet runners to the Microsoft.Data.SqlClient.PerformanceTests harness to measure previously reported performance hot spots (large async reads, MARS overhead, parallel OpenAsync, cancellation token overhead, sequential XML reads, JSON vs VARCHAR reads, transaction latency, and connection pool stress), along with configuration and wiring updates to run them via runnerconfig.json.

Changes:

Registers 8 new benchmark runners and gates each by a per-runner RunnerJob.Enabled config.
Extends the perf test config model (Config) and default runnerconfig.json with new runner entries plus new top-level flags.
Updates BenchmarkDotNet ManualConfig options/environment for more consistent perf runs (e.g., dont overwrite results, joined summary, server GC).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/Microsoft.Data.SqlClient/tests/PerformanceTests/runnerconfig.json	Adds new top-level flags and runner job entries; enables new runners by default and disables older ones.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/Program.cs	Loads config, applies AppContext switches / optional profiler wait, and invokes each runner when enabled.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/Config.cs	Adds new config fields and per-runner `RunnerJob` entries.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/BenchmarkConfig.cs	Updates BDN config options and sets server GC env var; joins summaries.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/AsyncLargeDataReadRunner.cs	New runner to compare sync vs async large VARBINARY streaming reads.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/MarsOverheadRunner.cs	New runner comparing query execution with MARS enabled/disabled (sync + async).
src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/ParallelAsyncConnectionRunner.cs	New runner opening many connections concurrently with pooling on/off.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/CancellationTokenReadAsyncRunner.cs	New runner measuring ReadAsync iteration overhead with/without CancellationToken.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/SequentialXmlReadRunner.cs	New runner targeting sequential XML read scaling across payload sizes.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/JsonVsVarcharReadRunner.cs	New runner comparing JSON vs VARCHAR read performance (disabled by default).
src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/BeginTransactionRunner.cs	New runner comparing transaction vs no-transaction latency (sync + async).
src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/ConnectionPoolStressRunner.cs	New stress runner for pooled open/close churn, mixed sync/async contention, and exhaustion/recovery.

apoorvdeshmukh

These benchmarks will be very helpful!
Wondering if it would be possible to establish a baseline for native memory consumption when running these benchmarks and monitor memory growth if it drifts too much from the established baseline? This may be beyond the current scope of the PR but worth looking into.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

cheenamalhotra · 2026-07-15T08:02:32Z

These benchmarks will be very helpful! Wondering if it would be possible to establish a baseline for native memory consumption when running these benchmarks and monitor memory growth if it drifts too much from the established baseline? This may be beyond the current scope of the PR but worth looking into.

Added optionally, could you try and confirm as well?
(since I'm testing on mac today, I'll test this later on Windows)

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 8 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

codecov · 2026-07-15T20:12:04Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.95%. Comparing base (fdebcd2) to head (d67bf7a).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4447      +/-   ##
==========================================
- Coverage   65.83%   63.95%   -1.89%     
==========================================
  Files         287      284       -3     
  Lines       43763    66786   +23023     
==========================================
+ Hits        28812    42712   +13900     
- Misses      14951    24074    +9123

Flag	Coverage Δ
CI-SqlClient	`?`
PR-SqlClient-Project	`63.95% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- AsyncLargeDataReadRunner: seed VARBINARY(MAX) row via CRYPT_GEN_RANDOM T-SQL instead of allocating a client-side byte[] and shipping it over the wire, and add [Params] for ReadBufferBytes so we can observe how the client read buffer size interacts with payload size. - CancellationTokenReadAsyncRunner: move CancellationTokenSource allocation to [IterationSetup] and disposal to [IterationCleanup] so only the per-row ReadAsync(CancellationToken) overhead is measured. - ConnectionPoolStressRunner: scale the RapidFireOpenClose per-task iteration count with MaxPoolSize/Parallelism so total checkouts stay proportional to pool capacity, and drop the unused System.Collections.Generic import. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 62d8a5ff-8bd4-4780-9715-748ea0d950aa

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Addressed feedback

- JsonVsVarcharReadRunner: use SqlDataReader.GetSqlJson(0).Value for the JSON case (sync and async) so the benchmark exercises the SqlJson accessor path implicated in #3499 instead of the shared GetString / GetFieldValueAsync<string> path used for VARCHAR. - ConnectionPoolStressRunner.BurstyTrafficPattern: spin up Parallelism concurrent tasks per burst instead of Parallelism/burstCount, so the configured Parallelism parameter actually drives observed concurrency. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 62d8a5ff-8bd4-4780-9715-748ea0d950aa

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

mdaigle · 2026-07-20T16:54:11Z

/azp run

azure-pipelines · 2026-07-20T16:54:47Z

Azure Pipelines: Successfully started running 3 pipeline(s).

Introduce performance tests

89d7ccd

Copilot AI review requested due to automatic review settings July 15, 2026 07:14

cheenamalhotra requested a review from a team as a code owner July 15, 2026 07:14

github-project-automation Bot added this to SqlClient Board Jul 15, 2026

github-project-automation Bot moved this to To triage in SqlClient Board Jul 15, 2026

cheenamalhotra added Performance 📈 Issues that are targeted to performance improvements. Area\Tests Issues that are targeted to tests or test projects labels Jul 15, 2026

Copilot started reviewing on behalf of cheenamalhotra July 15, 2026 07:15 View session

cheenamalhotra assigned mdaigle and paulmedynski Jul 15, 2026

Copilot AI reviewed Jul 15, 2026

View reviewed changes

apoorvdeshmukh reviewed Jul 15, 2026

View reviewed changes

Touch-ups and updates

efeed68

Copilot AI review requested due to automatic review settings July 15, 2026 07:33

Copilot started reviewing on behalf of cheenamalhotra July 15, 2026 07:34 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/BeginTransactionRunner.cs

Comment thread BUILDGUIDE.md Outdated

Enable Native profiling on Windows

5382321

Copilot AI review requested due to automatic review settings July 15, 2026 08:01

cheenamalhotra added this to the 7.1.0-preview3 milestone Jul 15, 2026

Copilot started reviewing on behalf of cheenamalhotra July 15, 2026 08:01 View session

cheenamalhotra moved this from To triage to In review in SqlClient Board Jul 15, 2026

cheenamalhotra assigned apoorvdeshmukh Jul 15, 2026

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Update doc, address comments

eb980d7

Copilot AI review requested due to automatic review settings July 15, 2026 08:13

Copilot started reviewing on behalf of cheenamalhotra July 15, 2026 08:13 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Apply suggestions from code review

d67bf7a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 15, 2026 17:07

github-project-automation Bot moved this from In review to Waiting for customer in SqlClient Board Jul 15, 2026

mdaigle mentioned this pull request Jul 16, 2026

Expand connection pool benchmark coverage for ChannelDbConnectionPool #4451

Closed

4 tasks

Copilot AI review requested due to automatic review settings July 16, 2026 20:03

cheenamalhotra dismissed mdaigle’s stale review via ad3ba33 July 16, 2026 20:03

Copilot started reviewing on behalf of cheenamalhotra July 16, 2026 20:04 View session

Copilot AI reviewed Jul 16, 2026

View reviewed changes

cheenamalhotra requested a review from paulmedynski July 16, 2026 20:25

Copilot AI review requested due to automatic review settings July 16, 2026 20:26

Copilot started reviewing on behalf of cheenamalhotra July 16, 2026 20:27 View session

Copilot AI reviewed Jul 16, 2026

cheenamalhotra enabled auto-merge (squash) July 17, 2026 17:20

cheenamalhotra requested review from apoorvdeshmukh, Copilot and mdaigle July 17, 2026 17:22

Copilot started reviewing on behalf of cheenamalhotra July 17, 2026 17:22 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Comment thread src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/SequentialXmlReadRunner.cs

paulmedynski approved these changes Jul 17, 2026

View reviewed changes

cheenamalhotra mentioned this pull request Jul 17, 2026

[Experimental] Perf benchmark follow-ups (stacked on #4447) #4455

Closed

4 tasks

mdaigle approved these changes Jul 20, 2026

View reviewed changes

apoorvdeshmukh approved these changes Jul 20, 2026

View reviewed changes

cheenamalhotra merged commit 36f4f94 into main Jul 20, 2026
335 of 359 checks passed

github-project-automation Bot moved this from Waiting for customer to Done in SqlClient Board Jul 20, 2026

cheenamalhotra deleted the dev/cheena/perf-project branch July 20, 2026 19:12

mdaigle mentioned this pull request Jul 20, 2026

Expand connection pool benchmark coverage for pool implementation A/B testing #4459

Open

4 tasks

Uh oh!

Conversation

cheenamalhotra commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

New runners

Supporting changes

Validation

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

apoorvdeshmukh left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

cheenamalhotra commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jul 15, 2026

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

mdaigle commented Jul 20, 2026

Uh oh!

azure-pipelines Bot commented Jul 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

cheenamalhotra commented Jul 15, 2026 •

edited

Loading

cheenamalhotra commented Jul 15, 2026 •

edited

Loading