Skip to content

Pass stdout to ThrowIfFailed in three runner list methods #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonrozsival merged 1 commit into from
May 12, 2026
Merged

Pass stdout to ThrowIfFailed in three runner list methods #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Xamarin.Android.Tools.AndroidSdk/Runners/AdbRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public virtual async Task<IReadOnlyList<AdbDeviceInfo>> ListDevicesAsync (Cancel
var psi = ProcessUtils.CreateProcessStartInfo (adbPath, "devices", "-l");
var exitCode = await ProcessUtils.StartProcess (psi, stdout, stderr, cancellationToken, environmentVariables).ConfigureAwait (false);

ProcessUtils.ThrowIfFailed (exitCode, "adb devices -l", stderr);
ProcessUtils.ThrowIfFailed (exitCode, "adb devices -l", stderr, stdout);

var devices = ParseAdbDevicesOutput (stdout.ToString ().Split ('\n'));

Expand Down
2 changes: 1 addition & 1 deletion src/Xamarin.Android.Tools.AndroidSdk/Runners/AvdManagerRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public async Task<IReadOnlyList<AvdInfo>> ListAvdsAsync (CancellationToken cance
logger.Invoke (TraceLevel.Verbose, "Running: avdmanager list avd");
var exitCode = await ProcessUtils.StartProcess (psi, stdout, stderr, cancellationToken, environmentVariables).ConfigureAwait (false);

ProcessUtils.ThrowIfFailed (exitCode, "avdmanager list avd", stderr);
ProcessUtils.ThrowIfFailed (exitCode, "avdmanager list avd", stderr, stdout);

return ParseAvdListOutput (stdout.ToString ());
}
Expand Down
2 changes: 1 addition & 1 deletion src/Xamarin.Android.Tools.AndroidSdk/Runners/EmulatorRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public async Task<IReadOnlyList<string>> ListAvdNamesAsync (CancellationToken ca

logger.Invoke (TraceLevel.Verbose, "Running: emulator -list-avds");
var exitCode = await ProcessUtils.StartProcess (psi, stdout, stderr, cancellationToken, environmentVariables).ConfigureAwait (false);
ProcessUtils.ThrowIfFailed (exitCode, "emulator -list-avds", stderr);
ProcessUtils.ThrowIfFailed (exitCode, "emulator -list-avds", stderr, stdout);

return ParseListAvdsOutput (stdout.ToString ());
}
Expand Down