-
Notifications
You must be signed in to change notification settings - Fork 567
[illink] Try to avoid System.Security.Cryptography.Primitives in linked apk #5451
Copy link
Copy link
Closed
Milestone
Description
Part of System.Security.Cryptography.Primitives.dll is preserved in linked simple XA apps.
Linker analyzer output:
--- Module:System.Security.Cryptography.Primitives.dll dependencies ----
Dependency #1
Module:System.Security.Cryptography.Primitives.dll
| TypeDef:System.Security.Cryptography.HashAlgorithm [12 deps]
| TypeDef:Java.Interop.Tools.JavaCallableWrappers.Crc64 [9 deps]
| Method:System.String Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager::GetPackageName(System.Type) [1 deps]
| Method:System.String Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager::ToJniName(System.Type,Java.Interop.ExportParameterKind) [2 deps]
| Method:System.String Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager::ToJniName(System.Type) [3 deps]
| Method:System.String Android.Runtime.JNIEnv::GetJniName(System.Type) [2 deps]
| Method:System.Void Java.Interop.TypeManager::RegisterType(System.String,System.Type) [2 deps]
| Method:System.Void Android.Runtime.JNIEnv::RegisterJniNatives(System.IntPtr,System.Int32,System.IntPtr,System.IntPtr,System.Int32) [1 deps]
| Other:C:\Users\rodo\android-toolchain\dotnet\packs\Microsoft.Android.Sdk.win-x64\11.0.100-ci.master.316\targets\..\PreserveLists\Mono.Android.xml
So it looks like it is only preserved through JavaNativeTypeManager::GetPackageName.
The Java.Interop.Tools.JavaCallableWrappers.Crc64 type is based on System.Security.Cryptography.HashAlgorithm.
That was useful, when we provided choice between md5 and crc64 for JCW names. We don't provide md5 anymore, so we don't really need to base it on System.Security.Cryptography.HashAlgorithm for JavaNativeTypeManager::GetPackageName.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels