Skip to content

[xaprepare] Retry runtime pack restore up to 3 times #10970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 2 commits into from
Mar 19, 2026
Merged

[xaprepare] Retry runtime pack restore up to 3 times #10970

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
333b9d9
[xaprepare] Retry runtime pack restore up to 3 times
jonathanpeppers Mar 18, 2026
8abf364
Apply suggestions from code review
grendello Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions build-tools/xaprepare/xaprepare/Steps/Step_InstallDotNetPreview.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,34 @@ protected override async Task<bool> Execute (Context context)

// Install runtime packs associated with the SDK previously installed.
var packageDownloadProj = Path.Combine (BuildPaths.XamarinAndroidSourceRoot, "build-tools", "xaprepare", "xaprepare", "package-download.proj");
var logPath = Path.Combine (Configurables.Paths.BuildBinDir, $"msbuild-{context.BuildTimeStamp}-download-runtime-packs.binlog");
var runner = new ProcessRunner (Configurables.Paths.DotNetPreviewTool, "restore",
ProcessRunner.QuoteArgument (packageDownloadProj),
"--configfile", Path.Combine (BuildPaths.XamarinAndroidSourceRoot, "NuGet.config"),
ProcessRunner.QuoteArgument ($"-bl:{logPath}"),
"--verbosity", "normal"
) {
EchoStandardOutput = true,
EchoStandardError = true,
};
if (!runner.Run ()) {
Log.ErrorLine ($"Failed to restore runtime packs using '{packageDownloadProj}'.");
var logPathBase = Path.Combine (Configurables.Paths.BuildBinDir, $"msbuild-{context.BuildTimeStamp}-download-runtime-packs");

const int maxAttempts = 3;
const int initialBackoffDelayMilliseconds = 2000;
bool restoreSucceeded = false;
for (int attempt = 1; attempt <= maxAttempts; attempt++) {
var logPath = $"{logPathBase}-attempt{attempt}.binlog";
var runner = new ProcessRunner (Configurables.Paths.DotNetPreviewTool, "restore",
ProcessRunner.QuoteArgument (packageDownloadProj),
"--configfile", Path.Combine (BuildPaths.XamarinAndroidSourceRoot, "NuGet.config"),
ProcessRunner.QuoteArgument ($"-bl:{logPath}"),
"--verbosity", "normal"
) {
Comment thread
grendello marked this conversation as resolved.
EchoStandardOutput = true,
EchoStandardError = true,
};
if (runner.Run ()) {
restoreSucceeded = true;
break;
}
if (attempt < maxAttempts) {
Log.WarningLine ($"Failed to restore runtime packs (attempt {attempt}/{maxAttempts}), retrying...");
var delayMilliseconds = initialBackoffDelayMilliseconds * (1 << (attempt - 1));
await Task.Delay (delayMilliseconds);
}
Comment thread
grendello marked this conversation as resolved.
}
if (!restoreSucceeded) {
Log.ErrorLine ($"Failed to restore runtime packs using '{packageDownloadProj}' after {maxAttempts} attempts.");
return false;
}

Expand Down