Remove obsolete RemoveAttributesBase from Microsoft.Android.Sdk.ILLink#11061
Merged
jonathanpeppers merged 1 commit intomainfrom Apr 1, 2026
Merged
Remove obsolete RemoveAttributesBase from Microsoft.Android.Sdk.ILLink#11061jonathanpeppers merged 1 commit intomainfrom
RemoveAttributesBase from Microsoft.Android.Sdk.ILLink#11061jonathanpeppers merged 1 commit intomainfrom
Conversation
Agent-Logs-Url: https://github.com/dotnet/android/sessions/4027cdd8-45a4-4446-a6b5-22f66e33b8c3 Co-authored-by: sbomer <787361+sbomer@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
sbomer
March 31, 2026 23:41
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a dead ILLink substep base class from Microsoft.Android.Sdk.ILLink to reduce the surface area and maintenance burden of the custom linker step assembly.
Changes:
- Deleted the unused
RemoveAttributesBaseabstractBaseSubStepimplementation and its attribute-walking removal logic.
Comments suppressed due to low confidence (1)
src/Microsoft.Android.Sdk.ILLink/RemoveAttributesBase.cs:1
- Removing
RemoveAttributesBasedeletes apublictype fromMicrosoft.Android.Sdk.ILLink, which is shipped as a tooling assembly (.../tools/Microsoft.Android.Sdk.ILLink.dll) and could be referenced by out-of-tree custom linker steps. If this is intended, it should be treated as an API break (e.g., documented in release notes) or softened by keeping a deprecated shim type (e.g., an[Obsolete]stub) for one release to preserve binary/source compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft.Android.Sdk.ILLinkstill carriedRemoveAttributesBaseeven though nothing in the project derives from or references it. This change removes the dead linker substep to keep the ILLink surface smaller and easier to navigate.Scope
src/Microsoft.Android.Sdk.ILLink/RemoveAttributesBase.csImpact
Result