[tests] Remove custom widget trimmable exclusion#11483
Merged
jonathanpeppers merged 1 commit intoMay 26, 2026
Merged
Conversation
The custom widget global-ref leak test is not a trimmable typemap-specific exclusion. Let it follow its normal test-level disposition instead of filtering it from the CoreCLRTrimmable instrumentation runner. Document the remaining Java.Interop InvokeVirtualFromConstructor exclusion as a known trimmable typemap limitation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Closed
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Xamarin.Android.RuntimeTests NUnit instrumentation used by Mono.Android.NET-Tests to stop hiding CustomWidgetTests.InflateCustomView_ShouldNotLeakGlobalRefs behind the CoreCLR trimmable exact-name exclusion list, so the test follows its normal test-level disposition. It also keeps the remaining Java.Interop exclusion in place and documents it as a known trimmable typemap limitation.
Changes:
- Removed the
Xamarin.Android.RuntimeTests.CustomWidgetTests.InflateCustomView_ShouldNotLeakGlobalRefsentry from the trimmableExcludedTestNameslist. - Kept
Java.InteropTests.InvokeVirtualFromConstructorTestsexcluded and clarified the rationale in the nearby comment.
simonrozsival
added
copilot
jonathanpeppers
approved these changes
May 26, 2026
jonathanpeppers
deleted the
dev/simonrozsival/remove-customwidget-trimmable-exclusion
branch
jonathanpeppers
pushed a commit
that referenced
this pull request
May 26, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Xamarin.Android.RuntimeTests.CustomWidgetTests.InflateCustomView_ShouldNotLeakGlobalRefsfrom the CoreCLRTrimmable exact-name exclusion listJava.InteropTests.InvokeVirtualFromConstructorTestsexcluded as a known trimmable typemap limitationInflateCustomView_ShouldNotLeakGlobalRefsis not a trimmable typemap-specific issue; it should follow its normal test-level disposition instead of being hidden by the trimmable runner.Validation
git diff --checkNUnitInstrumentation.csCloses #11099.