Replace trimmable manifest LINQ XML generation with lightweight XML model#11488
Draft
Copilot wants to merge 4 commits into
Draft
Replace trimmable manifest LINQ XML generation with lightweight XML model#11488Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Agent-Logs-Url: https://github.com/dotnet/android/sessions/7c90b070-d2df-4124-bea8-b0a5d9070cd1 Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/android/sessions/7c90b070-d2df-4124-bea8-b0a5d9070cd1 Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor manifest generation to use lower-allocation APIs
Replace trimmable manifest LINQ XML generation with lightweight XML model
May 25, 2026
Member
|
@copilot build fails: |
Agent-Logs-Url: https://github.com/dotnet/android/sessions/c005d968-85d0-4e7f-bea9-62a5ef0d74c9 Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Contributor
Author
... Fixed in e6721fd by aliasing the trimmable manifest model type in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trimmable typemap manifest path used
System.Xml.Linqfor template parsing, read/modify/write merging, rooting, and final output. This PR moves production manifest generation to a lower-allocation XML model while preserving existing manifest behavior.Manifest model
ManifestDocument/element/attribute model.XmlReader.XmlWriter.Generation pipeline
GenerateTrimmableTypeMap,TrimmableTypeMapGenerator, andGeneratedManifestto passManifestDocumentinstead ofXDocument.Files.CopyIfStreamChanged(...).Manifest merge helpers
XElementmutation to lightweight model mutation.Rooting
Example API shift: