Skip to content

[NativeAOT] Stabilize DoNotLeakWeakReferences by runtime-specific surfaced-object tolerance #11754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

[NativeAOT] Stabilize DoNotLeakWeakReferences by runtime-specific surfaced-object tolerance #11754

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8e7180
Initial plan
Copilot Jun 26, 2026
8590999
Adjust NativeAOT tolerance in DoNotLeakWeakReferences test
Copilot Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tests/Mono.Android-Tests/Mono.Android-Tests/Java.Interop/JnienvTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,10 +520,15 @@ public void DoNotLeakWeakReferences ()
// `Runtime.GetSurfacedObjects()` is process-global: NUnit/MTP
// infrastructure (per-test TestExecutionContext, listeners, Console
// capture, etc.) creates and releases transient Java.Lang.Object
// peers around every test, so the count drifts by a few entries
// between the snapshots below. Allow a small tolerance instead of
// requiring an exact count -- a real leak would dwarf this.
const int tolerance = 10;
// peers around every test, so the count drifts between snapshots.
//
// NativeAOT currently has a higher transient object count, so allow
// a wider tolerance there while keeping stricter checks elsewhere.
const int defaultTolerance = 10;
const int nativeAotTolerance = 30;
int tolerance = AppContext.TryGetSwitch ("Microsoft.Android.Runtime.RuntimeFeature.IsNativeAotRuntime", out bool isNativeAotRuntime) && isNativeAotRuntime
? nativeAotTolerance
: defaultTolerance;

WeakReference r = null;
Exception threadException = null;
Expand Down
Loading