Skip to content

Fix misleading XA4243 error when more than one JavaArtifact is specified #11785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 2 commits into from
Jun 29, 2026
Merged

Fix misleading XA4243 error when more than one JavaArtifact is specified #11785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25c5c31
Initial plan
Copilot Jun 29, 2026
09175f4
Add XA4256 for multiple JavaArtifact error
Copilot Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Properties/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,6 +1165,12 @@ To use a custom JDK path for a command line build, set the 'JavaSdkDirectory' MS
<value>Generated trimmable type map Java source '{0}' was not found.</value>
<comment>The following are literal names and should not be translated: trimmable type map, Java.
{0} - Full path to the generated Java source file</comment>
</data>
<data name="XA4256" xml:space="preserve">
<value>Only one '{0}' is allowed for '{1}' item '{2}'.</value>
<comment>{0} - MSBuild XML element name
{1} - MSBuild XML element name
{2} - MSBuild ItemSpec value</comment>
Comment thread
simonrozsival marked this conversation as resolved.
</data>
<data name="XA0142" xml:space="preserve">
<value>Command '{0}' failed.\n{1}</value>
Expand Down
3 changes: 1 addition & 2 deletions src/Xamarin.Android.Build.Tasks/Utilities/MavenExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,8 @@ public static bool TryParseJavaArtifact (this ITaskItem task, string type, TaskL
return false;
}

// TODO: Need a new message saying that only one JavaArtifact is allowed
if (artifacts.Count > 1) {
log.LogCodedError ("XA4243", Properties.Resources.XA4243, "JavaArtifact", type, task.ItemSpec);
log.LogCodedError ("XA4256", Properties.Resources.XA4256, "JavaArtifact", type, task.ItemSpec);
artifact = null;
return false;
}
Expand Down
Loading