[tests] fix failing NetStandardReferenceTest on Windows - #1470
Closed
jonathanpeppers wants to merge 1 commit into
Closed
[tests] fix failing NetStandardReferenceTest on Windows#1470jonathanpeppers wants to merge 1 commit into
jonathanpeppers wants to merge 1 commit into
Conversation
Context: https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1515010&tab=ms.vss-test-web.test-result-details Since f7c942d, the NUnit tests have been failing on Windows. The `NetStandardReferenceTest` is looking for `System.IO.Compression.dll` inside the APK, but it is not there. Looking into it, I don't see anything that explicitly needs `System.IO.Compression.dll`, so perhaps we really don't need to assert that this file exists.
Member
Author
|
It's also completely possible there is something wrong here, let me know what you think @dellis1972 |
Contributor
|
@jonathanpeppers nope. System.IO.Packaging has a dependency on System.IO.Compression. At least the |
Contributor
|
See 029a8b4 |
Contributor
|
I suspect it might be [1]. If that path starts with a |
Member
Author
|
Monday I’ll debug on Windows and see if I can fix it, I can update this PR with the fix. |
Contributor
|
Replaced by #1474 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1515010&tab=ms.vss-test-web.test-result-details
Since f7c942d, the NUnit tests have been failing on Windows. The
NetStandardReferenceTestis looking forSystem.IO.Compression.dllinside the APK, but it is not there.
Looking into it, I don't see anything that explicitly needs
System.IO.Compression.dll, so perhaps we really don't need to assertthat this file exists.