[plots] Do not mix Release and Release/Bundle measurements - #2401
Merged
Conversation
Fixes dotnet#2400 With dotnet#1683 we started to run and measure the apk tests with `BundleAssemblies=True` as well. To not mix and repeast these measurements with other ones, introduce `TestsFlavor` property in place of `TestsAotName` to distinguish the apk tests runs when collecting and processing measurements data. It is similar to what we did with AOT before. Example content of TestResult-Mono.Android_Tests-times.csv after the fix: last-Release,JNI.init-Release,init-Release,NUnit.results-Release,last-Release-Aot,JNI.init-Release-Aot,init-Release-Aot,NUnit.results-Release-Aot,last-Release-Bundle,JNI.init-Release-Bundle,init-Release-Bundle,NUnit.results-Release-Bundle 518,116,116,8347,647,86,86,7670,755,159,159,8416
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2400
With #1683 we started
to run and measure the apk tests with
BundleAssemblies=Trueaswell. To not mix and repeat these measurements with other ones,
introduce
TestsFlavorproperty in place ofTestsAotNametodistinguish the apk tests runs when collecting and processing
measurements data.
It is similar to what we did with AOT before.
Example content of TestResult-Mono.Android_Tests-times.csv after the
fix: