[build] remove usage of ant - #3696
Merged
Merged
Conversation
grendello
suggested changes
Sep 26, 2019
grendello
left a comment
grendello
left a comment
Contributor
There was a problem hiding this comment.
There's also a Linux dependency in build-tools/xaprepare/xaprepare/ConfigAndData/Dependencies/Linux.DebianCommon.cs - can you remove it as well, please?
Member
Author
|
👀 I keep finding more and more things that say |
Contributor
|
More context: Homebrew/homebrew-core#44608 |
Context: http://build.azdo.io/3085600 We have been hitting a build error of: ==> Downloading https://www-us.apache.org/dist/commons/bcel/binaries/bcel-6.3.1-bin.tar.gz stderr | curl: (22) The requested URL returned error: 404 Not Found stderr | Error: An exception occurred within a child process: stderr | DownloadError: Failed to download resource "ant--bcel" stderr | Download failed: https://www-us.apache.org/dist/commons/bcel/binaries/bcel-6.3.1-bin.tar.gz Error: Installation of ant failed Which is just coming from `brew install ant`. Looking into it, we only have usage of `<Ant/>` to build `proguard`. It looks like there are instructions to build it with `maven`, `ant`, `gradle`, `javac`, etc. I reworked proguard to be built with `gradle` the same way we are building `r8.jar`. This allows us to not need `ant` anymore.
jonathanpeppers
force-pushed
the
remove-ant
branch
from
September 26, 2019 15:53
a20b6b9 to
0eb894a
Compare
grendello
approved these changes
Sep 26, 2019
jonpryor
pushed a commit
that referenced
this pull request
Sep 26, 2019
Context: http://build.azdo.io/3085600 Context: Homebrew/homebrew-core#44608 On 2019-Sep-26, or thereabouts, we started seeing this build error: ==> Downloading https://www-us.apache.org/dist/commons/bcel/binaries/bcel-6.3.1-bin.tar.gz stderr | curl: (22) The requested URL returned error: 404 Not Found stderr | Error: An exception occurred within a child process: stderr | DownloadError: Failed to download resource "ant--bcel" stderr | Download failed: https://www-us.apache.org/dist/commons/bcel/binaries/bcel-6.3.1-bin.tar.gz Error: Installation of ant failed This is coming from `brew install ant`. Apparently, something related to the [Homebrew `ant` Formulae][0] has broken recently, and all attempts to use Homebrew to install `ant` are failing, worldwide. Looking into it, we only use `ant` and a related `<Ant/>` task to build `src/proguard`, and ProGuard has instructions to instead build with `maven`, `gradle`, and `javac` (among others). Meaning we don't actually *need* `ant` *at all*. I reworked `src/proguard` to be built with `gradle`, the same way we are building `r8.jar`. This allows us to not need `ant` anymore, and thus avoid the `brew install ant` error. [0]: https://formulae.brew.sh/formula/ant
jonpryor
pushed a commit
that referenced
this pull request
Sep 28, 2019
Context: http://build.azdo.io/3085600 Context: Homebrew/homebrew-core#44608 On 2019-Sep-26, or thereabouts, we started seeing this build error: ==> Downloading https://www-us.apache.org/dist/commons/bcel/binaries/bcel-6.3.1-bin.tar.gz stderr | curl: (22) The requested URL returned error: 404 Not Found stderr | Error: An exception occurred within a child process: stderr | DownloadError: Failed to download resource "ant--bcel" stderr | Download failed: https://www-us.apache.org/dist/commons/bcel/binaries/bcel-6.3.1-bin.tar.gz Error: Installation of ant failed This is coming from `brew install ant`. Apparently, something related to the [Homebrew `ant` Formulae][0] has broken recently, and all attempts to use Homebrew to install `ant` are failing, worldwide. Looking into it, we only use `ant` and a related `<Ant/>` task to build `src/proguard`, and ProGuard has instructions to instead build with `maven`, `gradle`, and `javac` (among others). Meaning we don't actually *need* `ant` *at all*. I reworked `src/proguard` to be built with `gradle`, the same way we are building `r8.jar`. This allows us to not need `ant` anymore, and thus avoid the `brew install ant` error. [0]: https://formulae.brew.sh/formula/ant
jonpryor
pushed a commit
that referenced
this pull request
Oct 1, 2019
Context: http://build.azdo.io/3085600 Context: Homebrew/homebrew-core#44608 On 2019-Sep-26, or thereabouts, we started seeing this build error: ==> Downloading https://www-us.apache.org/dist/commons/bcel/binaries/bcel-6.3.1-bin.tar.gz stderr | curl: (22) The requested URL returned error: 404 Not Found stderr | Error: An exception occurred within a child process: stderr | DownloadError: Failed to download resource "ant--bcel" stderr | Download failed: https://www-us.apache.org/dist/commons/bcel/binaries/bcel-6.3.1-bin.tar.gz Error: Installation of ant failed This is coming from `brew install ant`. Apparently, something related to the [Homebrew `ant` Formulae][0] has broken recently, and all attempts to use Homebrew to install `ant` are failing, worldwide. Looking into it, we only use `ant` and a related `<Ant/>` task to build `src/proguard`, and ProGuard has instructions to instead build with `maven`, `gradle`, and `javac` (among others). Meaning we don't actually *need* `ant` *at all*. I reworked `src/proguard` to be built with `gradle`, the same way we are building `r8.jar`. This allows us to not need `ant` anymore, and thus avoid the `brew install ant` error. [0]: https://formulae.brew.sh/formula/ant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: http://build.azdo.io/3085600
We have been hitting a build error of:
Which is just coming from
brew install ant.Looking into it, we only have usage of
<Ant/>to buildproguard.It looks like there are instructions to build it with
maven,ant,gradle,javac, etc.I reworked proguard to be built with
gradlethe same way we arebuilding
r8.jar. This allows us to not needantanymore.