[Mono.Android] Enable Map.Of methods that have more than 14 parameters. - #5106
Merged
Conversation
jpobst
marked this pull request as ready for review
September 11, 2020 17:59
jonpryor
pushed a commit
that referenced
this pull request
Sep 17, 2020
Context: dotnet/java-interop@56955d9 When binding API-30, we disabled some `java.util.Map.of()` overloads whicg took more than 14 parameters (a20be39), as we could not support them with C# `Action<…>`/`Func<…>` constructs. With dotnet/java-interop@56955d9a, the restriction to only bind methods with <= 14 parameters has been removed, allowing *all*` `Map.of()` methods to be bound. Enable all the `Map.of()` methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When binding API-30, we disabled a few overloads of
java.util.Map.of (...)that took more than 14 parameters, as we could not support them with C#Action/Funcconstructs.With dotnet/java-interop#632, we now support any number of parameters, so these methods can be enabled.