[Xamarin.Android.Build.Tasks] Add support for new InstantRun by dellis1972 · Pull Request #609 · dotnet/android

dellis1972 · 2017-05-26T10:52:01Z

This commit does a couple of things.

It reworks the monodroid-glue to copy any .so file it finds
in the .override directory over to the local app directory.
This should allow us to fast deploy native libraries. Which means
we no longer need to re-build the apk if a native library changes.
Removes and replaces the StubApplication with a new MultiDexLoader
ContentProvider. This provider is responsible for doing some the things
the previous StubApplication used to do. But because it is not
derived from an Application it means we should be able to support
custom Application types for our debug builds. The MultiDexLoader will
run before EVERYTHING else. This is so we can use dex files from the
override directory.
Move the Resource Patching code from StubApplication over to a
dedicated MonkeyPatcher class so it is all in one place.
Introduce a ResourceLoader ContentProvider which will deal with
patching the resource in a FastDev environment. This is to support Custom
Application classes.
The problem we had with this is the resource patching requires that the application
be created. But because the code was in the MultiDexLoader or StubApplication
this could not happen since it would require the app to exist. So the solution is to move
the patching to a dedicated ContentProvider which is loaded AFTER the user app has
been created.

jonpryor · 2017-05-26T13:54:39Z

This is failing .apk execution on the emulator:

java.lang.RuntimeException: Unable to get provider mono.android.MultiDexLoader: java.lang.ClassNotFoundException: Didn't find class "mono.android.MultiDexLoader" on path: DexPathList[[zip file "/data/app/Xamarin.Android.Locale_Tests-1/base.apk", zip file "/data/app/Xamarin.Android.Locale_Tests-1/base.apk"],nativeLibraryDirectories=[/data/app/Xamarin.Android.Locale_Tests-1/lib/x86, /data/app/Xamarin.Android.Locale_Tests-1/lib/x86, /vendor/lib, /system/lib]]
	at android.app.ActivityThread.installProvider(ActivityThread.java:4967)
	at android.app.ActivityThread.installContentProviders(ActivityThread.java:4559)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:4499)
	at android.app.ActivityThread.access$1500(ActivityThread.java:144)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1339)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:135)
	at android.app.ActivityThread.main(ActivityThread.java:5221)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)
Caused by: java.lang.ClassNotFoundException: Didn't find class "mono.android.MultiDexLoader" on path: DexPathList[[zip file "/data/app/Xamarin.Android.Locale_Tests-1/base.apk", zip file "/data/app/Xamarin.Android.Locale_Tests-1/base.apk"],nativeLibraryDirectories=[/data/app/Xamarin.Android.Locale_Tests-1/lib/x86, /data/app/Xamarin.Android.Locale_Tests-1/lib/x86, /vendor/lib, /system/lib]]
	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:511)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:469)
	at android.app.ActivityThread.installProvider(ActivityThread.java:4952)
	... 11 more
	Suppressed: java.lang.ClassNotFoundException: mono.android.MultiDexLoader
		at java.lang.Class.classForName(Native Method)
		at java.lang.BootClassLoader.findClass(ClassLoader.java:781)
		at java.lang.BootClassLoader.loadClass(ClassLoader.java:841)
		at java.lang.ClassLoader.loadClass(ClassLoader.java:504)
		... 13 more
	Caused by: java.lang.NoClassDefFoundError: Class not found using the boot class loader; no stack available

jonpryor · 2017-05-27T01:54:04Z

-	char *to_libmonoso = path_combine (to, "libmonosgen-2.0.so");
-	unlink (to_libmonoso);
+	char *to_file = path_combine (to, file);
+	unlink (to_file);


I realize that the original code didn't do this...but we should probably cleanup anyway. ;-)

This should probably be:

int r = unlink (to_file); if (r < 0 && errno != ENOENT) { log_warn (LOG_DEFAULT, "Unable to delete file `%s`", to_file); }

Though this raises entire questions about ensuring that memory is freed...

Which means I now get to do what I keep suggesting on ##csharp! "How do we sanely cleanup resources without using goto? By abusing do{}while!"

static void copy_file_to_internal_location (const char *to_dir, const char *from_dir, const char *file) { char *from_file = path_combine (from_dir, file); char *to_file = NULL; do { if (!from_file || !file_exists (from_file)) break; log_warn (LOG_DEFAULT, "Copying file `%s` from external location `%s` to internal location `%s`", file, from_dir, to_dir); to_file = path_combine (to_dir, file); if (!to_file) break; int r = unlink (to_file); if (r < 0 && errno != ENOENT) { log_warn (LOG_DEFAULT, "Unable to delete file `%s`: %s", to_file, strerror (errno)); break; } if (file_copy (to_file, from_file) < 0) { log_warn (LOG_DEFAULT, "Copy failed from `%s` to `%s`: %s", from_file, to_file, strerror (errno)); break; } set_user_executable (to_file); } while (0); free (from_file); free (to_file); }

@jonpryor do you still want me to implement this while loop?

jonpryor · 2017-05-27T01:57:55Z

+		if ((dir = monodroid_opendir (dir_path)) == NULL)
+			continue;
+
+		while (readdir_r (dir, &b, &e) == 0 && e) {


I suspect that this will break on the Windows build; if we add the full-mono-integration-build Labe and rebuildl, we'll find out. ;-)

Assuming this is the case, we'll need to add a monodroid_readdir() function to util.c and use it here.

jonpryor · 2017-05-27T02:03:39Z

+
+public class MultiDexLoader extends ContentProvider {
+
+	boolean created;


I don't see why we need this field. It doesn't appear to be used anywhere, other than onCreate().

dellis1972 · 2017-05-27T17:12:36Z

build

dellis1972 · 2017-05-27T21:31:53Z

@jonpryor I updated this and added the full build label. not sure if that did anything though? How can you tell?

jonpryor · 2017-05-30T13:19:26Z

How can you tell?

Normal PR build will only build one Mono.Android.dll, and ~3 ABIs for mono (if no bundle.zip exists): armv7, x86, "host".

full-mono-integration-build does everything that a non-PR build does, so all API levels, all the ABIs, both Debug and Release.

As such:

The full-mono-integration build takes longer.
If Mono was bumped, AOT-related tests more reliably pass, because the AOT compilers will exist. (In theory these should pass anyway, but historically they don't.)
If you download the oss*.zip build artifact, you'll see all the Mono.Android.dll assemblies. Ditto if you read the the log file.

jonpryor · 2017-05-30T13:22:53Z

I think this PR should also have a new test, "somewhere/somehow", which sets $(AndroidEnableMultiDex)=True.

I'm less certain on how this should look; perhaps we could make e.g. src/Mono.Android/Test/*.csproj into a shared project+.csproj "combo", and add a new tests/Runtime-MultiDex directory which references the shared project?

Or perhaps just a new "Hello, World"-esque test would be sufficient to test MultiDex?

Either way, this new test should also contain an Android.App.Application subclass, to ensure that this works. See also https://bugzilla.xamarin.com/show_bug.cgi?id=55050.

jonpryor · 2017-05-30T13:26:24Z

-	char *to_libmonoso = path_combine (to, "libmonosgen-2.0.so");
-	unlink (to_libmonoso);
+		if (dir_path == NULL || !directory_exists (dir_path)) {
+			if (dir_path != NULL)


No need to check for null. free(3) will accept the NULL pointer and ignore it:

The free() function.... If ptr is NULL, no operation is performed.

dellis1972 · 2017-06-07T16:14:51Z

build

dellis1972 · 2018-09-11T10:32:29Z

build

dellis1972 · 2018-09-13T18:11:10Z

build

jonpryor · 2018-09-17T15:38:45Z

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="utf-8"?>


Why do we have this file? It doesn't appear to be used from anywhere, and it's confusing being alongside Main.axml.

jonpryor · 2018-09-17T15:39:05Z

@@ -0,0 +1,49 @@
+<?xml version="1.0" encoding="utf-8"?>


Why do we have this file? It doesn't appear to be used from anywhere, and it's confusing being alongside NameFixups.axml.

jonpryor · 2018-09-17T16:31:57Z

Does this fix https://bugzilla.xamarin.com/show_bug.cgi?id=55050 ?

dellis1972 · 2018-09-17T17:28:05Z

No. There are still issues for debug (not for release) that need to be fixed (see my comments earlier). This is a step in the right direction though.

…

On Mon, 17 Sep 2018 at 17:32, Jonathan Pryor ***@***.***> wrote: Does this fix https://bugzilla.xamarin.com/show_bug.cgi?id=55050 ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#609 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAxeectAzZcHm-VZmjlFdQYNV4pdwWHUks5ub86FgaJpZM4NndPH> .

jonpryor · 2018-09-18T15:33:29Z

+				// Older platforms
+				Map activities = (HashMap) collection;
+				c = activities.values();
+			} else if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT &&


This will probably fail when building on e.g. API-10, as Build.VERSION_CODES.KITKAT won't exist.

dellis1972 · 2018-09-19T09:10:23Z

build

dellis1972 · 2018-09-24T09:51:59Z

build

This commit does a couple of things. 1) It reworks the monodroid-glue to copy any .so file it finds in the .__override__ directory over to the local app directory. This should allow us to fast deploy native libraries. Which means we no longer need to re-build the apk if a native library changes. 2) Replaces the StubApplication with a new MultiDexLoader ContentProvider. This provider is reposible for doing all the things the previous StubApplication used to do. But because it is not derived from an Application it means we can now support custom Application types for our debug builds.

dnfclas added the cla-already-signed label May 26, 2017

dellis1972 requested a review from jonpryor May 26, 2017 10:52

dellis1972 force-pushed the instantrun branch 2 times, most recently from 202adfc to d40bc5d Compare May 26, 2017 15:53

jonpryor reviewed May 27, 2017

View reviewed changes

Comment thread src/monodroid/jni/monodroid-glue.c

jonpryor reviewed May 27, 2017

View reviewed changes

Comment thread src/Xamarin.Android.Build.Tasks/Resources/MultiDexLoader.java

jonpryor reviewed May 27, 2017

View reviewed changes

dellis1972 added the full-mono-integration-build For PRs; run a full build (~6-10h for mono bumps), not the faster PR subset (~2h for mono bumps) label May 27, 2017

dellis1972 force-pushed the instantrun branch from d40bc5d to b3eb06c Compare May 27, 2017 20:55

jonpryor reviewed May 30, 2017

View reviewed changes

dellis1972 force-pushed the instantrun branch 2 times, most recently from 5ac892a to 619b55c Compare June 7, 2017 14:09

dellis1972 force-pushed the instantrun branch 3 times, most recently from 0a8566b to 5fb5ba2 Compare June 14, 2017 12:29

dellis1972 force-pushed the instantrun branch 2 times, most recently from a2ad397 to d91761a Compare June 21, 2017 11:15

dellis1972 force-pushed the instantrun branch from d91761a to 009a135 Compare July 26, 2017 11:45

jonpryor mentioned this pull request Aug 2, 2017

Add support for pre-loading app native libraries #713

Closed

dellis1972 force-pushed the instantrun branch from 009a135 to afc9bb6 Compare August 4, 2017 09:15

dellis1972 force-pushed the instantrun branch from afc9bb6 to 83c325b Compare September 22, 2017 10:53

dellis1972 force-pushed the instantrun branch from 83c325b to f418e73 Compare October 31, 2017 15:55

dellis1972 force-pushed the instantrun branch 4 times, most recently from ca83568 to 552bace Compare July 25, 2018 10:06

dellis1972 force-pushed the instantrun branch 5 times, most recently from 0c88697 to e8463e5 Compare August 30, 2018 12:50

dellis1972 force-pushed the instantrun branch from e8463e5 to 1442f8b Compare September 11, 2018 08:05

dellis1972 force-pushed the instantrun branch from 1442f8b to fcb2462 Compare September 12, 2018 15:11

dellis1972 force-pushed the instantrun branch 2 times, most recently from 833152b to c0d01a5 Compare September 14, 2018 08:57

jonpryor reviewed Sep 17, 2018

View reviewed changes

dellis1972 force-pushed the instantrun branch 3 times, most recently from 395d5ee to 4460c76 Compare September 18, 2018 12:06

jonpryor reviewed Sep 18, 2018

View reviewed changes

dellis1972 added the run-tests-release label Sep 19, 2018

dellis1972 added 2 commits September 25, 2018 12:27

Removed Logging

86d9fb5

jonathanpeppers mentioned this pull request Sep 27, 2018

[Xamarin.Android.Build.Tasks] CopyResource should fail with an error code #2237

Merged

jonpryor mentioned this pull request May 1, 2020

Bump to xamarin/Java.Interop/master@377c4c7a #4631

Merged


		public class MultiDexLoader extends ContentProvider {

		boolean created;

Uh oh!

Conversation

dellis1972 commented May 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonpryor commented May 26, 2017

Uh oh!

jonpryor May 27, 2017

Choose a reason for hiding this comment

Uh oh!

dellis1972 Jul 2, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonpryor May 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonpryor May 27, 2017

Choose a reason for hiding this comment

Uh oh!

dellis1972 commented May 27, 2017

Uh oh!

dellis1972 commented May 27, 2017

Uh oh!

jonpryor commented May 30, 2017

Uh oh!

jonpryor commented May 30, 2017

Uh oh!

jonpryor May 30, 2017

Choose a reason for hiding this comment

Uh oh!

dellis1972 commented Jun 7, 2017

Uh oh!

dellis1972 commented Sep 11, 2018

Uh oh!

dellis1972 commented Sep 13, 2018

Uh oh!

jonpryor Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

jonpryor Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

jonpryor commented Sep 17, 2018

Uh oh!

dellis1972 commented Sep 17, 2018 via email

Uh oh!

jonpryor Sep 18, 2018

Choose a reason for hiding this comment

Uh oh!

dellis1972 commented Sep 19, 2018

Uh oh!

dellis1972 commented Sep 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dellis1972 commented May 26, 2017 •

edited

Loading

jonpryor May 27, 2017 •

edited

Loading