[build] skip provisioning of Xamarin.Android on .NET lanes - #7646
Merged
Conversation
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7102687&view=logs&j=270ba80a-9de5-5c73-abb9-bb787532a07c&s=25cdcba1-3ecb-5490-0002-daf27c697525&t=306f7057-edf0-58b5-5004-8b3b311950d4&l=449 `provisionator` is a source of random failures like: [21:41:23 ERR] Error Xamarin.Provisioning.ProvisioningException: Failed to provision C:\a\_work\1\s\xamarin-android\Xamarin.Android.Sdk-13.1.99.88.vsix In this case, we were downloading a classic Xamarin.Android build for use on a test lane for `One .NET` tests? To make things better, let's skip this step completely for `One .NET` tests. We shouldn't need to provision classic Xamarin.Android on these test lanes. This also has the added benefit of faster test runs, just spot-checking the time spent on the above build: * Saves 1-2 min of time for `provisionator` on macOS lanes. * Saves up to ~24 min of time for `provisionator` on Windows lanes.
Member
Author
|
Seems like it is working, One .NET lanes:
VS legacy lanes:
|
jonathanpeppers
marked this pull request as ready for review
December 19, 2022 15:36
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jan 4, 2023
* main: [build] skip provisioning of Xamarin.Android on .NET lanes (dotnet#7646) Bump to dotnet/installer@1c4be07 8.0.100-alpha.1.22622.3 (dotnet#7657)
jonathanpeppers
added a commit
that referenced
this pull request
Mar 21, 2023
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7102687&view=logs&j=270ba80a-9de5-5c73-abb9-bb787532a07c&s=25cdcba1-3ecb-5490-0002-daf27c697525&t=306f7057-edf0-58b5-5004-8b3b311950d4&l=449 `provisionator` is a source of random failures like: [21:41:23 ERR] Error Xamarin.Provisioning.ProvisioningException: Failed to provision C:\a\_work\1\s\xamarin-android\Xamarin.Android.Sdk-13.1.99.88.vsix In this case, we were downloading a Classic Xamarin.Android build for use on a test lane for `One .NET` tests? Improve things, and skip this step completely for `One .NET` tests. We don't need to provision Classic Xamarin.Android on these lanes. This also has the added benefit of faster test runs, just spot-checking the time spent on the above build: * Saves 1-2 min of time for `provisionator` on macOS lanes. * Saves up to ~24 min of time for `provisionator` on Windows lanes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7102687&view=logs&j=270ba80a-9de5-5c73-abb9-bb787532a07c&s=25cdcba1-3ecb-5490-0002-daf27c697525&t=306f7057-edf0-58b5-5004-8b3b311950d4&l=449
provisionatoris a source of random failures like:In this case, we were downloading a classic Xamarin.Android build for use on a test lane for
One .NETtests?To make things better, let's skip this step completely for
One .NETtests. We shouldn't need to provision classic Xamarin.Android on these test lanes.This also has the added benefit of faster test runs, just spot-checking the time spent on the above build:
provisionatoron macOS lanes.provisionatoron Windows lanes.