[Xamarin.Android.Build.Tasks] honour minSdkVersion from library uses-sdk Manifest Files. - #7862
Closed
dellis1972 wants to merge 2 commits into
Closed
[Xamarin.Android.Build.Tasks] honour minSdkVersion from library uses-sdk Manifest Files.#7862dellis1972 wants to merge 2 commits into
minSdkVersion from library uses-sdk Manifest Files.#7862dellis1972 wants to merge 2 commits into
Conversation
minSdkVersion from library uses-sdk Manifest Files.
dellis1972
force-pushed
the
WI1720987
branch
4 times, most recently
from
March 14, 2023 10:24
2456b55 to
9bbc232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://i.azdo.io/1720987
When users add an empty
uses-sdkelement to their AndroidManifest.xml file they can introduce the following error.This is because the
minSdkof libaries was not taken into consideration when genereting the final manifest file.Currently if the user does NOT specify a
minSdkin the manifest it will default toXABuildConfig.NDKMinimumApiAvailablewhich is currently set to19. This then causes the conflict.What we should do is figure out what the
minSdkvalue is from any library projects and then use that if the user doesnot provide one.