[Mono.Android] Generate API docs for .NET Android - #8007
Merged
Conversation
The `UpdateExternalDocumentation` target has been updated to run against the .NET version of Mono.Android.dll, as we no longer need to generate docs and doc redirects for the classic installers.
Member
Author
|
This fixes the more urgent portion of #7974 |
jpobst
reviewed
May 4, 2023
Member
Author
|
The issues in the Docs build are already known and tracked in dotnet/java-interop#1071, this should be good to merge. |
jonpryor
reviewed
May 9, 2023
|
|
||
| <Target Name="_FindDocSourceFiles"> | ||
| <ItemGroup> | ||
| <_MsxDocSourceFile Include="$(XamarinAndroidSourcePath)external\android-api-docs\**" /> |
Contributor
There was a problem hiding this comment.
This should probably be …\android-api-docs\docs\Mono.Android\en, because:
_ExportMsxDocwon't use any of the other files.- It'll be slightly fewer files to glob (8760 vs. 9914)
I do wonder how long it'll take to fill the item group, but I don't know of a better solution…
Member
Author
There was a problem hiding this comment.
Good catch, I updated this to use the more specific path.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
May 11, 2023
* main: Bump to xamarin/Java.Interop/main@6aedf1c (dotnet#8027) [ci] Simplify WearOS Emulator test job. (dotnet#8024) [Mono.Android] Generate API docs for .NET Android (dotnet#8007)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
UpdateExternalDocumentationtarget has been updated to run againstthe .NET version of Mono.Android.dll, as we no longer need to generate
docs and doc redirects for the classic installers.