Workaround breaking change to IObjectWriter - #2664
Conversation
NuGet broke IObjectWriter by adding members. We cannot implement those members since we cannot take a dependency on the new NuGet without breaking existing consumers on 2.x SDKs. Remove the workaround since the runtime.json NuGet's API generates is functionally equivalent, and we don't need to be compatible with old NuGet clients (EG: dnx) where it may not be.
| } | ||
|
|
||
| /// <summary> | ||
| /// works around a bug in NuGet that writes an empty import array, |
There was a problem hiding this comment.
These differences used to matter when we were building packages that we wanted to work in older clients. We don't need that any more so I'm ok absorbing the change to the runtime.json files generated. I tested restoring our packages that contain this runtime.json format with the latest SDK.
|
Do we have 2.x consumers at all? Who is using this package besides corefx and standard? |
CoreCLR and core-setup too. I'm ok with accepting the diff in the runtime.json. For the most part these types of runtime.jsons are going away in the shipping product. They're being replaced with runtime packs. We're only using this to flow the transport packages. /cc @dagood |
3 participants
NuGet broke IObjectWriter by adding members. We cannot implement those
members since we cannot take a dependency on the new NuGet without breaking
existing consumers on 2.x SDKs.
Remove the workaround since the runtime.json NuGet's API generates is
functionally equivalent, and we don't need to be compatible with old NuGet
clients (EG: dnx) where it may not be.