Workaround for projects that do not import Common targets - #2677
Merged
Conversation
ViktorHofer
approved these changes
May 2, 2019
ericstj
reviewed
May 3, 2019
ericstj
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you for adding this!
Member
|
@tmat build break: https://dnceng.visualstudio.com/internal/_build/results?buildId=177331 |
ViktorHofer
pushed a commit
that referenced
this pull request
May 3, 2019
Member
Author
|
Forgot about cross-targeting: #2683 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some projects do not import Common targets, so BeforeCommonTargets.targets doesn't get imported.
Opened issue #2676 to track removal of the workaround.