Skip to content

Few changes for corefx to follow arcade artifacts convention for packages - #3542

Merged
safern merged 2 commits into
dotnet:masterfrom
safern:UsePackageArtifactsConvention
Aug 7, 2019
Merged

Few changes for corefx to follow arcade artifacts convention for packages#3542
safern merged 2 commits into
dotnet:masterfrom
safern:UsePackageArtifactsConvention

Conversation

@safern

@safern safern commented Aug 1, 2019

Copy link
Copy Markdown
Member

No description provided.

@safern
safern requested review from ViktorHofer and ericstj August 1, 2019 23:36
@safern

safern commented Aug 2, 2019

Copy link
Copy Markdown
Member Author

Added NO MERGE label as we need to react in corefx and that change is not ready yet.

ericstj
ericstj reviewed Aug 2, 2019
View reviewed changes
Comment thread src/Microsoft.DotNet.Build.Tasks.Packaging/src/build/Packaging.common.targets Outdated
ericstj
ericstj approved these changes Aug 2, 2019
View reviewed changes

@ericstj ericstj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment

@safern

safern commented Aug 2, 2019

Copy link
Copy Markdown
Member Author

/azp run arcade-ci

@azure-pipelines

azure-pipelines Bot commented Aug 2, 2019

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

ViktorHofer
ViktorHofer reviewed Aug 4, 2019
View reviewed changes

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why you are using a different property now? ArtifactsPackagesDir

@safern

safern commented Aug 5, 2019

Copy link
Copy Markdown
Member Author

Can you explain why you are using a different property now? ArtifactsPackagesDir

Since we're moving towards following arcade's convention, PackageOutputPath will point to ArtifactsPackagesDir\{Shipping|NonShipping} depending on the pkproj's settings, if it has IsShipping=true or not. However, we want the specs and reports to be all together at the root dir for packages rather than having 1 specs/reports directory on each Shipping and NonShipping directory, ArtifactsPackagesDir is that root dir.

@ViktorHofer

ViktorHofer commented Aug 7, 2019

Copy link
Copy Markdown
Member

OK 👌

@safern

safern commented Aug 7, 2019

Copy link
Copy Markdown
Member Author

Merging as I will be sending a PR to corefx shortly.

@safern
safern merged commit 77597ba into dotnet:master Aug 7, 2019
@safern
safern deleted the UsePackageArtifactsConvention branch August 7, 2019 22:13
@safern safern mentioned this pull request Aug 7, 2019
Merged
@dagood dagood mentioned this pull request Aug 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments
@ericstj ericstj ericstj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@safern @ViktorHofer @ericstj