Mop up sharedfx tool package migration; GeneratePackageOnBuild feedback fix#4073
Merged
Conversation
Ports fix made to sharedfx targets before Core-Setup migrated to the shared tooling SDK. dotnet/core-setup@b903a6e
Ports fix made to sharedfx targets before Core-Setup migrated to the shared tooling SDK. dotnet/core-setup@558f70f
Describe why GeneratePackageOnBuild is necessary for the Arcade SDK project and removes it from the sharedfx tooling project, where it isn't needed.
MichaelSimons
approved these changes
Oct 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports a couple of changes that were made to
framework.dependency.targetsin Core-Setup before its copy of these targets were deleted. (I linked origin commits in the commit descriptions.)One is still in progress (dotnet/core-setup#8468,
Enable building for arm64 on arm64) but I anticipate it going in soon.Also fixes #4035. Removing
GeneratePackageOnBuildsaves devs some time by avoiding building the sharedfx SDK nupkg unnecessarily. (FYI @alexperovich)