Skip to content

Fix SymStore targets to fail build on error - #4379

Merged
mmitche merged 1 commit into
dotnet:masterfrom
tmat:FixSymStoreTargets
Nov 18, 2019
Merged

Fix SymStore targets to fail build on error#4379
mmitche merged 1 commit into
dotnet:masterfrom
tmat:FixSymStoreTargets

Conversation

@tmat

@tmat tmat commented Nov 16, 2019

Copy link
Copy Markdown
Member

Fixes #4370

@tmat

tmat commented Nov 16, 2019

Copy link
Copy Markdown
Member Author

@mmitche FYI

@mmitche

mmitche commented Nov 18, 2019

Copy link
Copy Markdown
Member

Thanks, I had a similar fix in progress. Fixes: #4370

@mmitche
mmitche merged commit 200445a into dotnet:master Nov 18, 2019
@ViktorHofer

Copy link
Copy Markdown
Member

This broke the runtime repo:

D:\a\1\s\.packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.19568.10\tools\SymStore.targets(22,41): error MSB4057: The target "CoreCompile" does not exist in the project. [D:\a\1\s\src\libraries\build.proj]
##[error].packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.19568.10\tools\SymStore.targets(22,41): error MSB4057: (NETCORE_ENGINEERING_TELEMETRY=Build) The target "CoreCompile" does not exist in the project.

https://dev.azure.com/dnceng/public/_build/results?buildId=432049

We could work around this and add the CoreCompile target of course but I would like to understand/discuss the break first.

@tmat

tmat commented Nov 19, 2019

Copy link
Copy Markdown
Member Author

I'll take a look.

@tmat

tmat commented Nov 19, 2019

Copy link
Copy Markdown
Member Author

I think we can fix it by replacing CoreCompile, which is only available in managed projects, with Build.

@tmat

tmat commented Nov 19, 2019

Copy link
Copy Markdown
Member Author

Fix #4401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_DeployPortableSymbolsToSymStore failures do not report to msbuild

3 participants