Skip to content

Update Android build script with latest NDK - #4915

Merged
janvorli merged 1 commit into
dotnet:masterfrom
am11:feature/android-revival
Mar 6, 2020
Merged

Update Android build script with latest NDK#4915
janvorli merged 1 commit into
dotnet:masterfrom
am11:feature/android-revival

Conversation

@am11

@am11 am11 commented Feb 25, 2020

Copy link
Copy Markdown
Member
  • Update build script to use NDK r21.
  • Download and check package manifest from termux pkgs repository
    for versions.
    • This completes a TODO in build-android.sh file.
  • Update common/cross/toolchain.cmake to include Android.
    • Starting from r19, an OOTB toolchain is provided, so a minimal
      configuration is required before calling that toolchain.
  • Remove old Android toolchains.

@am11

am11 commented Feb 25, 2020

Copy link
Copy Markdown
Member Author

cc @janvorli, continuing on dotnet/runtime#32746, this is patch 2/3 for Android.

* Update build script to use NDK r21.
* Download and check [package manifest][1] from termux pkgs repository
  for versions.
  * This completes a TODO in `build-android.sh` file.
* Update common/cross/toolchain.cmake to include Android.
  * Starting from r19, an OOTB toolchain is provided, so a minimal
    configuration is required before calling that toolchain.
* Remove old Android toolchains.

[1]: http://termux.net/dists/stable/main/binary-aarch64/Packages
@am11

am11 commented Mar 4, 2020

Copy link
Copy Markdown
Member Author

@janvorli, could you please take a look?

@janvorli janvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli
janvorli merged commit 5835aff into dotnet:master Mar 6, 2020
@am11
am11 deleted the feature/android-revival branch March 6, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants