Skip to content

Initial support for automated testing via Xharness - #5369

Merged
MattGal merged 3 commits into
dotnet:masterfrom
MattGal:xharness-support-prototyping
May 7, 2020
Merged

Initial support for automated testing via Xharness#5369
MattGal merged 3 commits into
dotnet:masterfrom
MattGal:xharness-support-prototyping

Conversation

@MattGal

@MattGal MattGal commented Apr 28, 2020

Copy link
Copy Markdown
Member

I believe this is ready to work, but we still need Helix queues in staging that can run Android emulators to be turned on and working. This PR is mostly to check that the machinery works up to the point that the app fails to run on a Windows machine due to the lack of an Android emulator.

Putting this up here for feedback while I work on:

@MattGal
MattGal requested a review from alexperovich April 28, 2020 18:32
@MattGal MattGal self-assigned this Apr 28, 2020
@MattGal
MattGal force-pushed the xharness-support-prototyping branch from f8326c6 to 4b4e732 Compare April 28, 2020 18:36
@ChadNedzlek

Copy link
Copy Markdown
Contributor

This is going to be a pretty big conflict with #5347, you and @alexperovich will probably want to sort that out. :-)

Comment thread src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessWorkItems.cs Outdated
@alexperovich

Copy link
Copy Markdown
Member

This is going to be a pretty big conflict with #5347, you and @alexperovich will probably want to sort that out. :-)

This doesn't actually have any conflict with my change. This change is in the helix testing stuff, mine is for the arcade sdk local testing stuff.

Comment thread src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessWorkItems.cs Outdated
Comment thread src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessWorkItems.cs Outdated
{
using (var zip = new ZipArchive(fs, ZipArchiveMode.Create, true))
{
zip.CreateEntryFromFile(fileToZip, fileName);

@ChadNedzlek ChadNedzlek Apr 28, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do this Async if we didn't use the CreateEntryFromFile helper. If we are zipping up a lot of files, that might be relevant.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best I can tell from the folks working on it, we'll have one payload-per-project, of which each is a separate msbuild invocation, so given that and that all the parallel things shared a disk synch made most sense.

Comment thread src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessWorkItems.cs Outdated
Comment thread src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessWorkItems.cs Outdated
Comment thread src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessWorkItems.cs Outdated
Comment thread src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessWorkItems.cs Outdated
Comment thread src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessWorkItems.cs Outdated
Comment thread src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessWorkItems.cs Outdated
Comment thread src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessWorkItems.cs Outdated
Comment thread src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessWorkItems.cs Outdated
Comment thread src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessWorkItems.cs Outdated
@MattGal
MattGal force-pushed the xharness-support-prototyping branch from 4b4e732 to 5f45d76 Compare May 7, 2020 00:01
@MattGal MattGal changed the title WIP: Xharness support prototyping Initial support for automated testing via Xharness May 7, 2020
@MattGal
MattGal marked this pull request as ready for review May 7, 2020 20:35
@MattGal

MattGal commented May 7, 2020

Copy link
Copy Markdown
Member Author

Everything worked except that the XUnit results didn't seem to ingest properly. SInce both tried, and my only usage of the reporters is to call them, I'm going to merge here; I'll work with @alexperovich to try to understand why

@MattGal
MattGal merged commit da5fb85 into dotnet:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants