Pack arcade-powered source-build intermediate nupkgs before publish step - #6177
Merged
Conversation
crummel
approved these changes
Sep 15, 2020
dseefeld
approved these changes
Sep 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #6121, I added
AfterSourceBuild.projfor prebuilt checks, and moved intermediate nupkg generation toAfterSourceBuild.proj. This PR fixes the order so the intermediate nupkg is generated beforePublish.projruns. Otherwise, the official build fails to find/publish it.I also added the usual
Publish artifacts.comment abovePublish.projfor consistency with the other steps. It might help point out thatPublish.projisn't part ofPerform post-source-build tasks.