Skip to content

Use file version instead of assembly version when setting file version. - #6654

Merged
jkoritzinsky merged 1 commit into
dotnet:masterfrom
jkoritzinsky:fix-file-version
Dec 7, 2020
Merged

Use file version instead of assembly version when setting file version.#6654
jkoritzinsky merged 1 commit into
dotnet:masterfrom
jkoritzinsky:fix-file-version

Conversation

@jkoritzinsky

Copy link
Copy Markdown
Member

Contributes to unblocking dotnet/aspnetcore#27845

@JunTaoLuo

Copy link
Copy Markdown

Given that this wasn't a problem in 5.0, was this logic changed in 6.0? I'm kinda curious how this slipped through the cracks until now.

@jkoritzinsky

Copy link
Copy Markdown
Member Author

Yes, we switched to completely new tooling for .NET 6 (added in #5714) that has the goal of eventually being used across the whole stack to build shared frameworks.

@jkoritzinsky
jkoritzinsky merged commit d8c996b into dotnet:master Dec 7, 2020
@jkoritzinsky
jkoritzinsky deleted the fix-file-version branch December 7, 2020 22:13

@ericstj ericstj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants