BufferSegment use ArrayPool for over-sized allocs - #13495
Merged
Conversation
benaadams
requested review from
Tratcher,
analogrelay,
halter73 and
jkotalik
as code owners
August 27, 2019 23:32
dcarr42
reviewed
Aug 28, 2019
…rHelpers/ConcurrentPipeWriter.cs Co-Authored-By: David Carr <dvdcrr77@googlemail.com>
halter73
approved these changes
Aug 28, 2019
halter73
left a comment
halter73
left a comment
Member
There was a problem hiding this comment.
If we're using the ArrayPool for too-large buffers everywhere else like in StreamPipeWriter, it makes sense for ConcurrentPipeWriter to do the same.
Member
|
/azp run AspNetCore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
The CI failures will hopefully be fixed by #13532 |
Member
|
/azp run AspNetCore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
amcasey
added
area-networking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than allocating an array; as per dotnet/corefx#39643