Log heartbeat duration for slow heartbeats

[Kahbazi]

Fixes #12760

[halter73]

Thanks!

[springy76]

In which netcore version will this finally show up? 3.1.6 still shows old text without duration.

[Tratcher]

The change is only in 5.0 previews.

[nblumhardt]

Just a heads-up, this introduced a small bug, the parameters to the log event are out of order, so the messages are nonsensical.

LoggerMessage.Define<TimeSpan, TimeSpan, DateTimeOffset>(LogLevel.Warning, new EventId(22, nameof(HeartbeatSlow)), @"As of ""{now}"", the heartbeat has been running for ""{heartbeatDuration}"" which is longer than ""{interval}"". This could be caused by thread pool starvation.")

Should be DateTimeOffset (now), TimeSpan (heartbeatDuration), TimeSpan (interval).

[ghost]

Hi @nblumhardt. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

[BrennanConroy]

Thanks, we've already fixed it up in 6.0 and are backporting the fix to 5.0 #31080