Correct the site extensions builds - #25406
Conversation
|
This was part of #24983 but I found it's mandatory for us to build with stable versions. That is, the servicing readiness tests failed without this work. |
|
Internal build https://dev.azure.com/dnceng/internal/_build/results?buildId=793405 included this commit if you want to see the created packages |
|
@Pilchie any objection to tell-mode here❔ |
|
I'm not against tell-mode, but I'm not sure that removing 2.2 is the right thing to do. Even though it's out of support, 2.2 is still available on Azure AppService :( |
Thought we'd decided it was fine in the "[dotnet/aspnetcore] Update branding to 6.0.0 Alpha1 (#24983)" email thread (outside the referenced PR)❔ |
|
It's easier to just keep 2.2 there and we can remove it in 6.0 |
wtgodbe
left a comment
There was a problem hiding this comment.
Looks good contingent on resolution of the 2.2 issue. Makes sense to me to keep including the 2.2 packages for now
- handle differing SiteExtensions package versions - the arch-specific packages don't stabilize when final package does - update 3.1 packages in bundle to 3.1.7 version - remove useless empty folder from LoggingBranch (arch-specific) package - double slashes help nobody but add an empty-named level in the package nit: fix a binary log filename
0fdf17d to
4a2937a
Compare
|
🆙📅 to rebase and restore the 2.2 site extensions inclusion in the bundle (this time in the correct PR 😺) |
nit: fix a binary log filename