Update JSCallResultTypeHelper.cs

[MackinnonBuck]

Description

Currently, each .NET->JavaScript interop call results in JSCallResultTypeHelper.FromGeneric<TResult>() comparing TResult with up to three IJSObjectReference types. We can optimize this slightly for the general case by first checking if typeof(TResult).Assembly matches the assembly containing JSCallResultType before performing the other checks.

Customer Impact

Customers may see a slight performance improvement for JS interop calls.

Regression?

No.

Risk

Very small risk. This is a small change and existing tests cover this area.

Addresses #25624

[dougbu]

This PR fixes a build break. We need it in ASAP

[halter73]

@dougbu There's also #25629 that just fixes the build break.

[dougbu]

@Pilchie should I proactively merge this to unbreak the build, letting @SteveSandersonMS and @MackinnonBuck follow up on the C# change if there's something wrong there❔

[halter73]

@Pilchie There's also #25629 that just fixes the build with the C# change.

[dougbu]

Never mind this PR @Pilchie except for its ask mode aspect. I merged #25629 because that "just" unbreaks the build. Many thanks @MackinnonBuck❕

[halter73]

Can this be tested?

[Pilchie]

@MackinnonBuck please ping when CI is green and this is signed off. Dismissing @dougbu's signoff since I presume it was based on just the build fix.

The initial review was to pull in the build fix (which has been resolved), not the C# change.

[SteveSandersonMS]

Great!

[ghost]

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

[Pilchie]

Approved for .NET 5.0 RC2.