Reduce references to Microsoft.AspNetCore.App.Runtime.csproj - #25836
Merged
Conversation
dougbu
commented
Sep 12, 2020
dougbu
commented
Contributor
- dotnet-watch builds against runtime in the SDK
- other projects build after runtime project due to Ref.csproj reference
- but, when the targeting packs aren't building, there's no reason to use Ref.csproj
- followup on 76fbd1a and 8496266, reducing parallelism in build
dougbu
commented
Sep 12, 2020
| Include="$(RepoRoot)src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj" | ||
| PrivateAssets="All" | ||
| ReferenceOutputAssembly="false" | ||
| SkipGetTargetFrameworkProperties="true" /> |
Contributor
Author
There was a problem hiding this comment.
Not useful due to $(DoNotApplyWorkaroundsToMicrosoftAspNetCoreApp) setting earlier in this file
Contributor
Author
|
@Pilchie if approved and passes CI, |
dougbu
added
the
area-infrastructure
Contributor
Author
Member
Yes. |
Contributor
Author
|
/ping reviewers This PR is green and approved for tell mode. |
JunTaoLuo
approved these changes
Sep 14, 2020
wtgodbe
approved these changes
Sep 14, 2020
pranavkm
approved these changes
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.