Skip to content

Remove obsolete AzureAd - #27955

Closed
HaoK wants to merge 7 commits into
mainfrom
haok/ripazuread
Closed

Remove obsolete AzureAd#27955
HaoK wants to merge 7 commits into
mainfrom
haok/ripazuread

Conversation

@HaoK

@HaoK HaoK commented Nov 18, 2020

Copy link
Copy Markdown
Member

Part of #27529

@Tratcher

Copy link
Copy Markdown
Member

There's a lot of discussion on #27529 about if removing these APIs is actually necessary. Yes they've been replaced, but the old ones still work so do we need to forcibly break people that are still using them?

Is there a clear functional problem here driving the removal?

@HaoK

HaoK commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

These have been a constant source of issues and errors, doesn't an LTS seem like a good time to encourage them to move to the intended final destination? Basically bullet 2

What's the maintenance cost of keeping the API around? This includes things like the number of issues reported by users, whether there's a lot of flaky tests associated with the API, etc.

@HaoK

HaoK commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

This seems analogous to our Azure Key Vault configuration provider which we also dropped rather than keeping around with obsolete since its an externally owned feature

@Tratcher

Copy link
Copy Markdown
Member

We already moved the templates so that should cut down on the incoming issues. The main concern is if we're forcing change on people who weren't broken. That's @blowdart's call.

@HaoK

HaoK commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

Right, I checked with @blowdart before opening the PR :)

@blowdart

Copy link
Copy Markdown
Contributor

I lean on kill it off, obviously. People do need to change, because the v1 endpoint will retire, probably before the LTS expiry. Same with the app creation API.

@blowdart

Copy link
Copy Markdown
Contributor

This apparently needs a wider discussion :)

@Pilchie Pilchie added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Nov 18, 2020
@Tratcher

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@Tratcher Tratcher added this to the 6.0-preview1 milestone Nov 19, 2020
@HaoK
HaoK marked this pull request as ready for review January 4, 2021 21:04
@HaoK

HaoK commented Jan 4, 2021

Copy link
Copy Markdown
Member Author

@blowdart did we get everything straightened out on the process side on your end for approval?

@blowdart

blowdart commented Jan 4, 2021

Copy link
Copy Markdown
Contributor

We did not. The thread is ongoing. I'll ressurect it. We may have to keep it for a while longer.

@mkArtakMSFT mkArtakMSFT removed this from the 6.0-preview1 milestone Apr 22, 2021
@blowdart

Copy link
Copy Markdown
Contributor

Closing until v7

@blowdart blowdart closed this Apr 29, 2021
@HaoK
HaoK deleted the haok/ripazuread branch July 20, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants