Fix SignalRClientWorksWithLongPolling - #32818
Merged
TanayParikh merged 3 commits intoJun 3, 2021
Merged
Conversation
ghost
added
the
TanayParikh
marked this pull request as ready for review
May 19, 2021 19:45
SteveSandersonMS
approved these changes
May 20, 2021
TanayParikh
commented
Jun 2, 2021
|
|
||
| [Fact] | ||
| [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27156")] | ||
| public void SignalRClientWorksWithLongPolling() |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| public void SignalRClientWorksWithLongPolling() | |
| [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27156")] | |
| public void SignalRClientWorksWithLongPolling() |
Contributor
Author
There was a problem hiding this comment.
We aren't removing the QuarantinedTest attribute for fixed tests now, so just added it back in. PR originally created prior to your email of changes to the quarantine process.
Contributor
Author
There was a problem hiding this comment.
Updated PR title to reflect that we're just fixing the test, not unquarantining it.
TanayParikh
enabled auto-merge (squash)
June 2, 2021 23:23
TanayParikh
deleted the
taparik/unquarantineSignalRClientWorksWithLongPolling
branch
June 3, 2021 00:44
TanayParikh
changed the title
SignalRClientWorksWithLongPollingSignalRClientWorksWithLongPolling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure seems to be due to the same resource sharing issues seen in #32281
Confirmed that the test has a steady pass rate in the quarantine env (4 failures are un-related).