Skip to content

[main] Work around #41937 and stop skipping tests - #42140

Merged
dougbu merged 2 commits into
dotnet:mainfrom
dougbu:dougbu/reenable.tests.41937/main
Jun 11, 2022
Merged

[main] Work around #41937 and stop skipping tests#42140
dougbu merged 2 commits into
dotnet:mainfrom
dougbu:dougbu/reenable.tests.41937/main

Conversation

@dougbu

@dougbu dougbu commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

[main] Work around #41937

  • unset ASPNETCORE_ENVIRONMENT on Helix agents

[main] Undo #41937 changes

dougbu added 2 commits June 10, 2022 15:42
@dougbu
[main] Work around #41937
d854ff6 
- unset `ASPNETCORE_ENVIRONMENT` on Helix agents
@dougbu
[main] Undo #41937 changes
c749d7c 
- tests look green with workaround in place
- revert "Skip failing template tests (#41936)"
- was commit ce0edc0
@dougbu
dougbu requested review from a team, Pilchie and wtgodbe as code owners June 10, 2022 23:14
@dougbu dougbu mentioned this pull request Jun 10, 2022
Closed
@dougbu
dougbu enabled auto-merge June 10, 2022 23:20
@dougbu

dougbu commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Enabled auto-merge. Will use an actual merge to keep the revert part separate.

@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 10, 2022
@ghost

ghost commented Jun 10, 2022

Copy link
Copy Markdown

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@dougbu
dougbu merged commit ae281e9 into dotnet:main Jun 11, 2022
@dougbu
dougbu deleted the dougbu/reenable.tests.41937/main branch June 11, 2022 00:57
@ghost ghost added this to the 7.0-preview6 milestone Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoK HaoK HaoK approved these changes
@wtgodbe wtgodbe wtgodbe approved these changes
@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy
@MattGal MattGal Awaiting requested review from MattGal
@MackinnonBuck MackinnonBuck Awaiting requested review from MackinnonBuck
@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

7.0-preview6

Development

Successfully merging this pull request may close these issues.

3 participants

@dougbu @HaoK @wtgodbe