Skip to content

[main] Update dependencies from dotnet/runtime dotnet/efcore - #42800

Merged
wtgodbe merged 12 commits into
mainfrom
darc-main-18025408-a34f-4524-903e-0a4f6d6d1433
Jul 22, 2022
Merged

[main] Update dependencies from dotnet/runtime dotnet/efcore#42800
wtgodbe merged 12 commits into
mainfrom
darc-main-18025408-a34f-4524-903e-0a4f6d6d1433

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jul 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/efcore

  • Subscription: 8ce5251e-8269-419d-3b2a-08d8b8050dda
  • Build: 20220722.2
  • Date Produced: July 22, 2022 1:15:51 PM UTC
  • Commit: 8152d15aafda30657d623341631f52541400f6e3
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 32db3699-5666-45da-a1b7-08d8b804cd75
  • Build: 20220721.7
  • Date Produced: July 22, 2022 7:50:34 AM UTC
  • Commit: 4cadf9ad741fb1f0c1b09967c62aef01a8c152ee
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20220…
8b7ec23 
…718.3

dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools
 From Version 7.0.0-rc.1.22368.2 -> To Version 7.0.0-rc.1.22368.3
@dotnet-maestro
dotnet-maestro Bot requested review from a team, dougbu and wtgodbe as code owners July 19, 2022 02:00
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Jul 19, 2022
ghost
ghost approved these changes Jul 19, 2022
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
3491b84 
…0718.8

Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 7.0.0-rc.1.22367.4 -> To Version 7.0.0-rc.1.22368.8
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Jul 19, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
b7aa692 
…0719.9

Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 7.0.0-rc.1.22367.4 -> To Version 7.0.0-rc.1.22369.9
@captainsafia

captainsafia commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

Blocked due to a bug introduced via dotnet/runtime#72299.

@dougbu

dougbu commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

Is there a dotnet/runtime issue @captainsafia❔

@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20220…
d17182d 
…720.1

dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools
 From Version 7.0.0-rc.1.22368.2 -> To Version 7.0.0-rc.1.22370.1
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Jul 20, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20220…
b309341 
…720.2

dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools
 From Version 7.0.0-rc.1.22368.2 -> To Version 7.0.0-rc.1.22370.2
@captainsafia

captainsafia commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

Is there a dotnet/runtime issue @captainsafia❔

No issue, but a PR has already been opened with a resolution at dotnet/runtime#72535

Safia Abdalla and others added 2 commits July 20, 2022 20:56
Safia Abdalla
Merge branch 'main' into darc-main-18025408-a34f-4524-903e-0a4f6d6d1433
c1a55b1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
b2354db 
…0721.1

Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 7.0.0-rc.1.22367.4 -> To Version 7.0.0-rc.1.22371.1
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/runtime dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Jul 21, 2022
@captainsafia

captainsafia commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

Update: there are still issues but an issue has been opened at dotnet/runtime#72622.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20220…
0df61bc 
…721.1

dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools
 From Version 7.0.0-rc.1.22368.2 -> To Version 7.0.0-rc.1.22371.1
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Jul 22, 2022
dotnet-maestro Bot added 2 commits July 22, 2022 11:51
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20220…
1391626 
…722.1

dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools
 From Version 7.0.0-rc.1.22368.2 -> To Version 7.0.0-rc.1.22372.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
2311397 
…0721.7

Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.DirectoryServices.Protocols , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 7.0.0-rc.1.22367.4 -> To Version 7.0.0-rc.1.22371.7
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/runtime dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Jul 22, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20220…
2966c9f 
…722.2

dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools
 From Version 7.0.0-rc.1.22368.2 -> To Version 7.0.0-rc.1.22372.2
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Jul 22, 2022
@wtgodbe

wtgodbe commented Jul 22, 2022

Copy link
Copy Markdown
Member

@jkoritzinsky we've ingested the fix but are still seeing errors like the following, are they related?

D:\a_work\1\s.packages\microsoft.extensions.hostfactoryresolver.sources\7.0.0-rc.1.22371.7\contentFiles\cs\netstandard2.0\HostFactoryResolver.cs(41,47): error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [D:\a_work\1\s\src\Tools\GetDocumentInsider\src\GetDocument.Insider.csproj]

@jkoritzinsky

jkoritzinsky commented Jul 22, 2022

Copy link
Copy Markdown
Member

No, that failure is unrelated.

@jkoritzinsky

jkoritzinsky commented Jul 22, 2022

Copy link
Copy Markdown
Member

@dotnet/area-extensions-hosting I think are the right people for that.

@eerhardt

eerhardt commented Jul 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

HostFactoryResolver.cs(41,47): error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

Looks like @stephentoub made that change yesterday in dotnet/runtime#72568. @wtgodbe - I can add it back if you need it. Do you know why GetDocument.Insider.csproj isn't using nullable annotations?

Maybe the other option is to add:

<NoWarn>$(NoWarn);nullable</NoWarn>

to the GetDocument.Insider.csproj?

@stephentoub

stephentoub commented Jul 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Maybe the other option is to add:

Yes, this is what we've now done in runtime... for any production libs that aren't yet fully annotated / reviewed, they're:

<Nullable>disable</Nullable>
<NoWarn>$(NoWarn);nullable</NoWarn>

and for any projects where we don't care about public API surface area (e.g. tests) and haven't fully enabled nullable warnings, they're:

<Nullable>annotations</Nullable>

@stephentoub

stephentoub commented Jul 22, 2022

Copy link
Copy Markdown
Member

microsoft.extensions.hostfactoryresolver.sources

We ship a source package from runtime to aspnetcore?

@eerhardt

eerhardt commented Jul 22, 2022

Copy link
Copy Markdown
Member

We ship a source package from runtime to aspnetcore?

Yes. And it is also used in efcore.

https://github.com/dotnet/efcore/blob/0bf05f11eff485386d9ca5e08191ff5fbdb7451b/eng/Version.Details.xml#L32

@wtgodbe
wtgodbe requested a review from Pilchie as a code owner July 22, 2022 17:36
@wtgodbe
wtgodbe enabled auto-merge (squash) July 22, 2022 18:31
@wtgodbe
wtgodbe merged commit c5e2c47 into main Jul 22, 2022
@wtgodbe
wtgodbe deleted the darc-main-18025408-a34f-4524-903e-0a4f6d6d1433 branch July 22, 2022 19:04
@ghost ghost added this to the 7.0-rc1 milestone Jul 22, 2022
@dougbu

dougbu commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

@wtgodbe don't forget to shorten the commit description for PRs like this one. The 13192 characters in c5e2c47 take up more than 1/3 of the available space for all environment variables. See https://devblogs.microsoft.com/oldnewthing/20100203-00/?p=15083 for the details. Got very lucky the official build of this commit and the rolling build succeeded.

We should probably add more information about this restriction to https://github.com/dotnet/aspnetcore-internal/blob/main/docs/operations/dependency_prs.md. Could you please handle that❔

@wtgodbe

wtgodbe commented Aug 1, 2022

Copy link
Copy Markdown
Member

https://github.com/dotnet/aspnetcore-internal/pull/4109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes
@dougbu dougbu Awaiting requested review from dougbu
@Pilchie Pilchie Awaiting requested review from Pilchie
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼

Projects

None yet

Milestone

7.0-rc1

Development

Successfully merging this pull request may close these issues.

6 participants

@captainsafia @dougbu @wtgodbe @jkoritzinsky @eerhardt @stephentoub