Skip all non-template tests in internal Windows test job#65211
Merged
MackinnonBuck merged 7 commits intomainfrom Jan 26, 2026
Merged
Skip all non-template tests in internal Windows test job#65211MackinnonBuck merged 7 commits intomainfrom
MackinnonBuck merged 7 commits intomainfrom
Conversation
wtgodbe
requested review from
a team,
BrennanConroy,
JamesNK and
halter73
as code owners
github-actions
bot
added
the
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull request overview
This PR skips non-template tests in the internal Windows test job to avoid restoring vulnerable Kestrel 2.2 packages and Chrome, which are now disallowed by SFI (presumably Security/Compliance infrastructure). The internal build leg only needs template dependencies registered for Component Governance.
Changes:
- Excluded IIS NewShim test projects from internal builds to avoid vulnerable package restoration
- Removed Chrome installation step from internal Windows test jobs
- Updated Helix Ubuntu test queue from 22.04 to 24.04
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Servers/IIS/IIS/test/testassets/InProcessNewShimWebSite/InProcessNewShimWebSite.csproj | Added ExcludeFromBuild condition for internal builds to skip project with Kestrel 2.2 dependency |
| src/Servers/IIS/IIS/test/IIS.NewShim.FunctionalTests/IIS.NewShim.FunctionalTests.csproj | Added SkipTests and ExcludeFromBuild conditions for internal builds |
| eng/targets/Helix.targets | Updated Ubuntu test queue version from 22.04 to 24.04 |
| eng/targets/Helix.Common.props | Updated Ubuntu test queue version from 22.04 to 24.04 |
| .azure/pipelines/jobs/default-build.yml | Removed Chrome installation step for internal Windows test jobs |
| .azure/pipelines/ci.yml | Added OnlyTestProjectTemplates parameter to build args for internal Windows test job |
MackinnonBuck
approved these changes
Jan 26, 2026
Member
MackinnonBuck
left a comment
MackinnonBuck
left a comment
There was a problem hiding this comment.
Thanks for addressing this!
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
Contributor
|
@wtgodbe backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128 |
10 tasks
Copilot AI
added a commit
that referenced
this pull request
Feb 2, 2026
…est job Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
wtgodbe
added a commit
that referenced
this pull request
Feb 3, 2026
…65301) * Initial plan * Backport PR #65211: Skip all non-template tests in internal Windows test job Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com> * Restore first Chrome installation block per review feedback Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows us to avoid restoring vulnerable Kestrel 2.2 package, and restoring Chrome, which is now disallowed by SFI. We only build this leg internally to get the template dependencies registered for CG, so that's all we care about anyways.