Add FileExtensionSignInfo for .cab to fix unsigned cab files inside ANCM MSIs#66443
Merged
Merged
Conversation
github-actions
Bot
added
the
needs-area-label
dotnet-policy-service
Bot
added
the
community-contribution
This was referenced Apr 23, 2026
Open
This was referenced Apr 27, 2026
Merged
Merged
Contributor
There was a problem hiding this comment.
Pull request overview
Adds signing configuration so .cab cabinet archives produced/embedded by ANCM MSI builds are code-signed, addressing signing compliance failures for unsigned CAB payloads.
Changes:
- Add a
FileExtensionSignInfoentry to sign.cabfiles using theMicrosoft400certificate. - Document the intent in
eng/Signing.propsnear existing signing exclusions.
Comment on lines
+35
to
+36
| <!-- Sign cabinet archives embedded inside MSI installers (ANCM, hosting bundle, etc.) --> | ||
| <FileExtensionSignInfo Include=".cab" CertificateName="Microsoft400" /> |
There was a problem hiding this comment.
The new .cab signing rule is inside the ItemGroup labeled "Code sign exclusions", which now mixes exclusions (CertificateName="None") with a positive signing rule. Consider moving the .cab entry to a separate ItemGroup (or updating the label) to keep the intent clear for future edits.
Contributor
Author
There was a problem hiding this comment.
Good catch - moved the .cab entry into its own ItemGroup (Label=Container signing) above the exclusions group. This keeps the intent clear: exclusions are None, container signing rules are separate.
jesuszarate
force-pushed
the
dev/jezarat/sign-cab-files
branch
from
e6d8b33 to
c22892a
Compare
jesuszarate
force-pushed
the
dev/jezarat/sign-cab-files
branch
from
3d8c2ee to
4e17ba2
Compare
jesuszarate
requested review from
a team,
BrennanConroy,
halter73 and
tdykstra
as code owners
jesuszarate
force-pushed
the
dev/jezarat/sign-cab-files
branch
2 times, most recently
from
a1ec329 to
1be622d
Compare
Add FileExtensionSignInfo for .cat so catalog files covering customer-modifiable JS templates are signed with Microsoft400. Update .js exclusion comment to clarify: JS files are excluded from Authenticode because they are customer-modifiable templates, covered by catalog signing instead. VS signing compliance bugs: 2951246, 2991694
jesuszarate
force-pushed
the
dev/jezarat/sign-cab-files
branch
from
1be622d to
d2458f8
Compare
wtgodbe
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\ CertificateName=\Microsoft400\ />
\\
Affected payloads
Precedent
Same fix pattern applied in other dotnet repos:
Tracking