Split IValidatableInfo to multiple interfaces by Youssef1313 · Pull Request #67183 · dotnet/aspnetcore

Youssef1313 · 2026-06-12T12:22:23Z

Copilot

Pull request overview

This PR implements the API proposal from #67080 by splitting IValidatableInfo into separate interfaces for type, property, and parameter validation metadata, and updates ValidationOptions/resolvers/generator output to use the more specific contracts.

Changes:

Introduces IValidatableTypeInfo, IValidatablePropertyInfo, and IValidatableParameterInfo, and removes IValidatableInfo.
Updates ValidationOptions and IValidatableInfoResolver signatures to return the new interface types, and updates runtime/generator resolver implementations accordingly.
Refactors property lookup to call IValidatableTypeInfo.TryFindProperty(...) instead of relying on ValidatableTypeInfo type checks in ValidationOptions.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/Validation/src/ValidationOptions.cs	Updates `TryGet...` APIs to return the split interface types and uses `TryFindProperty` for property resolution.
src/Validation/src/ValidateContext.cs	Adjusts documentation text related to the (now removed) `IValidatableInfo`.
src/Validation/src/ValidatableTypeInfo.cs	Implements `IValidatableTypeInfo` and exposes `TryFindProperty` for property lookup.
src/Validation/src/ValidatablePropertyInfo.cs	Switches base class to `IValidatablePropertyInfo`.
src/Validation/src/ValidatableParameterInfo.cs	Switches base class to `IValidatableParameterInfo`.
src/Validation/src/RuntimeValidatableParameterInfoResolver.cs	Updates resolver method signatures to the new interface types.
src/Validation/src/PublicAPI.Unshipped.txt	Records removals/additions for the interface split and updated APIs.
src/Validation/src/IValidatableTypeInfo.cs	Adds new interface for type validation metadata + property lookup.
src/Validation/src/IValidatablePropertyInfo.cs	Adds new interface for property validation metadata.
src/Validation/src/IValidatableParameterInfo.cs	Renames/replaces `IValidatableInfo` with the parameter-specific interface.
src/Validation/src/IValidatableInfoResolver.cs	Updates resolver interface to return the new interface types.
src/Validation/gen/Emitters/ValidationsGenerator.Emitter.cs	Updates generated resolver signatures/assignments to the new interface types.

Comments suppressed due to low confidence (1)

src/Validation/src/IValidatableParameterInfo.cs:12

The interface split introduces new names, but there are still many references to the removed IValidatableInfo across the repo (e.g., src/Http/Routing/src/ValidationEndpointFilterFactory.cs, src/Components/Forms/src/EditContextDataAnnotationsExtensions.cs, src/Http/Http/perf/Microbenchmarks/ValidatableTypesBenchmark.cs, and multiple Validation tests/snapshots). These will cause compilation failures unless updated to IValidatableTypeInfo/IValidatableParameterInfo/IValidatablePropertyInfo as appropriate.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

DeagleGross · 2026-06-15T14:12:44Z

-/// Represents an interface for validating a value.
+/// Represents an interface for validating a value of a parameter.
 /// </summary>
 [Experimental("ASP0029", UrlFormat = "https://aka.ms/aspnet/analyzer/{0}")]


just to confirm: we did not plan to remove [Experimental] on the new types?

Not yet. That needs to be another API review, I think.

The ask here was only to split the interfaces. Removing experimental and reviewing the whole API surface is a different question.

Youssef1313 · 2026-06-15T18:05:24Z

@copilot Update baseline for Microsoft.Extensions.Validation.GeneratorTests so that the tests pass.

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>

Copilot · 2026-06-15T18:15:37Z

@copilot Update baseline for Microsoft.Extensions.Validation.GeneratorTests so that the tests pass.

Updated the generator test baselines so Microsoft.Extensions.Validation.GeneratorTests pass. Addressed in commit f23337d7.

BrennanConroy · 2026-06-15T21:57:22Z

        }

+        var baseType = Type.BaseType;
+        while (baseType is not null)


nit: We used to have a baseType != typeof(object) check here

It's a small extra call to TryGetValidatableTypeInfo which will most likely return false right away.

And if one of the resolvers (custom IValidatableInfoResolver) is able to resolve typeof(object), then we should actually be respecting it and not silently dropping it IMO, so it's more correct to consider typeof(object).

BrennanConroy · 2026-06-15T22:00:07Z

        DisplayNameInfo = displayNameInfo;
        _membersCount = members.Count;
-        _superTypes = type.GetAllImplementedTypes();
+        _implementedInterfaces = type.GetInterfaces();


Any particular reason to change this? Looks like it just adds mostly duplicated code.

As I'm refactoring the code to avoid the ValidatableTypeInfo type check in this code path, the recursion can no longer call into FindLocalMember and instead needs to call into TryFindProperty.

If I blindly loop over all subtypes and call TryFindProperty, the algorithm will become exponential, as the direct subtype could already search the base types, and then the base types search the same base types again, etc. However, for interfaces, we want to make sure we walk all interfaces.

So I refactored it in a way that we walk all interfaces, but then we walk only the first base type for which we have an IValidatableTypeInfo implementation.

BrennanConroy · 2026-06-15T22:09:31Z

Link the issue to this PR please.

Youssef1313 · 2026-06-16T07:18:42Z

Link the issue to this PR please.

Ahh, Copilot keeps overwriting the PR description 😕

Youssef1313 · 2026-06-16T12:39:04Z

/ba-g macOS instability

Split IValidatableInfo to multiple interfaces

a51a754

Copilot AI review requested due to automatic review settings June 12, 2026 12:22

Copilot started reviewing on behalf of Youssef1313 June 12, 2026 12:22 View session

Copilot AI reviewed Jun 12, 2026

View reviewed changes

Youssef1313 and others added 3 commits June 12, 2026 14:27

Re-write

315341d

Apply suggestions from code review

f7c631c

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Update EditContextDataAnnotationsExtensions.cs

b825a3f

Youssef1313 requested a review from a team as a code owner June 12, 2026 13:43

Update ValidatablePropertyInfo.cs

60e4c79

build-analysis Bot mentioned this pull request Jun 12, 2026

Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922

Open

3 tasks

Youssef1313 added 5 commits June 12, 2026 16:23

Update ValidatableTypeInfo.cs

3f3c975

Update ValidatablePropertyInfo.cs

65dc223

Update PublicAPI.Unshipped.txt

9b7b33e

Fix PublicAPI.Unshipped.txt

fead5cf

Update ValidationEndpointFilterFactory.cs

7920117

Youssef1313 requested a review from halter73 as a code owner June 12, 2026 14:57

This was referenced Jun 12, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

Youssef1313 added 2 commits June 13, 2026 15:01

Fix tests

f3f148f

Update ValidatableTypesBenchmark.cs

880d08f

Youssef1313 requested a review from BrennanConroy as a code owner June 15, 2026 10:51

Update EditContextValidatableInfoFieldTest.cs

8a6cbe0

DeagleGross approved these changes Jun 15, 2026

View reviewed changes

Merge branch 'main' into dev/ygerges/split-interfaces

86936a2

Copilot started work on behalf of Youssef1313 June 15, 2026 18:06 View session

Update validation generator test baselines

f23337d

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>

Copilot finished work on behalf of Youssef1313 June 15, 2026 18:16

Fix tests

fd5d8b0

BrennanConroy approved these changes Jun 15, 2026

View reviewed changes

oroztocil approved these changes Jun 16, 2026

View reviewed changes

Youssef1313 merged commit becbe4b into main Jun 16, 2026
23 of 25 checks passed

Youssef1313 deleted the dev/ygerges/split-interfaces branch June 16, 2026 12:39

dotnet-maestro Bot mentioned this pull request Jun 23, 2026

[main] Source code updates from dotnet/aspnetcore dotnet/dotnet#7330

Merged

dotnet-milestone-bot Bot added this to the 11.0-preview6 milestone Jun 23, 2026

danroth27 mentioned this pull request Jul 10, 2026

[release-notes] ASP.NET Core in .NET 11 Preview 6 dotnet/core#10456

Merged

Youssef1313 added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-validation Issues related to model validation in minimal and controller-based APIs labels Jul 20, 2026

Uh oh!

Conversation

Youssef1313 commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DeagleGross Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Youssef1313 Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Youssef1313 commented Jun 15, 2026

Uh oh!

Copilot AI commented Jun 15, 2026

Uh oh!

BrennanConroy Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Youssef1313 Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

BrennanConroy Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Youssef1313 Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

BrennanConroy commented Jun 15, 2026

Uh oh!

Youssef1313 commented Jun 16, 2026

Uh oh!

Youssef1313 commented Jun 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Youssef1313 commented Jun 12, 2026 •

edited

Loading