Harden host filtering middleware matching leading dot when using wildcard - #67265
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens wildcard host matching in HostString.MatchesAny to prevent *.example.com-style patterns from accepting hosts that begin with a dot (e.g., ..example.com), addressing the host filtering bypass described in #66652.
Changes:
- Tighten subdomain wildcard matching to require the host not start with
.when matching*.patterns. - Add a regression test ensuring
..example.com:443does not match*.example.com.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Http/Http.Abstractions/src/HostString.cs | Adds an additional condition to block wildcard matches when the host begins with .. |
| src/Http/Http.Abstractions/test/HostStringTest.cs | Adds a regression case to ensure ..example.com:443 does not match *.example.com. |
javiercn
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66652. Related to #66582.