API review rename of AnchorMode - #67313
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the API review decision to rename VirtualizeAnchorMode.Beginning to VirtualizeAnchorMode.Start, updates Virtualize<TItem>.AnchorMode’s default accordingly, and adjusts the VirtualizeItemComparerAnalyzer to use concurrent collections.
Changes:
- Rename
VirtualizeAnchorMode.BeginningtoStart, including XML docs andVirtualize<TItem>.AnchorModedefault value. - Update Components unit tests and BasicTestApp test assets to use
Start. - Change the analyzer’s per-operation-block tracking collections to concurrent variants.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Components/Web/test/Virtualization/VirtualizeTest.cs | Updates test helper default anchor mode to Start. |
| src/Components/Web/src/Virtualization/VirtualizeAnchorMode.cs | Renames enum member Beginning → Start and updates docs. |
| src/Components/Web/src/Virtualization/Virtualize.cs | Updates AnchorMode default and doc reference to Start. |
| src/Components/Web/src/PublicAPI.Unshipped.txt | Updates public API baseline for the renamed enum member. |
| src/Components/test/testassets/BasicTestApp/VirtualizationAnchorModeWindowScroll.razor | Updates UI and defaults to use Start. |
| src/Components/test/testassets/BasicTestApp/VirtualizationAnchorMode.razor | Updates UI and defaults to use Start. |
| src/Components/Analyzers/src/VirtualizeItemComparerAnalyzer.cs | Switches internal tracking collections to concurrent types. |
Youssef1313
reviewed
Jun 19, 2026
Youssef1313
reviewed
Jun 19, 2026
…elying on Roslyn's undocumented callback order. Since all state is now local to the block, it's fine to use plain Stack/List.
Youssef1313
approved these changes
Jun 24, 2026
Youssef1313
left a comment
Youssef1313
left a comment
Member
There was a problem hiding this comment.
- Analyzer change LGTM.
- API name is changed according to the API review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename following the decision in #66799 (comment).
Fixes #66799