[Quarantine] AddValidationIntegrationTest.FormWithNestedValidation_Works#67700
Closed
DeagleGross wants to merge 1 commit into
Closed
[Quarantine] AddValidationIntegrationTest.FormWithNestedValidation_Works#67700DeagleGross wants to merge 1 commit into
DeagleGross wants to merge 1 commit into
Conversation
Test fails ~30% of the time (24 of last 80 aspnetcore-components-e2e builds, including 4 on refs/heads/main), across 20 different unrelated PRs. Signature: form validation summary asserts 6 required-field messages but only 1 is present, suggesting a race between form submission and Blazor rendering the full summary. Tracking issue: dotnet#67699 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Quarantines the flaky Blazor E2E test AddValidationIntegrationTest.FormWithNestedValidation_Works so CI can sequester it while the underlying issue is investigated (tracked in #67699).
Changes:
- Add
QuarantinedTestattribute toFormWithNestedValidation_Works. - Add the required
Microsoft.AspNetCore.InternalTestingusing for the quarantine attribute.
Show a summary per file
| File | Description |
|---|---|
| src/Components/test/E2ETest/ServerRenderingTests/AddValidationIntegrationTest.cs | Marks the flaky E2E test as quarantined (links to issue #67699) so failures don’t block unrelated PRs. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Member
|
@DeagleGross Should be already fixed by #67680 Has the test failed on main after this was merged? |
Member
|
Based on Copilot analysis, the test has not failed once since the fix was merged. |
Member
|
+1 to @oroztocil, let's not quarantine this unless it fails again after #67680 |
Member
Author
|
Sorry, missinterpreted test failures in #67635; closing the PR then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quarantines the flaky Blazor E2E test
AddValidationIntegrationTest.FormWithNestedValidation_Works.Failure rate
Analyzing the last 80
aspnetcore-components-e2ebuilds (~24 hours):refs/heads/main(~33% of main runs in the window)Failure signature
The test submits a form and asserts the validation summary contains 6 required-field messages, but only the first one is present. Looks like a Selenium/Blazor race between the submit click and the summary rendering.
Example failing builds
+or-sign #67635)Tracking
/cc @dotnet/aspnetcore-blazor