Run Blazor E2E tests on Microsoft.Extensions.Validation changes - #67702
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Azure DevOps PR path filters for the Blazor Components E2E pipelines so that changes to Microsoft.Extensions.Validation (src/Validation) also trigger the aspnetcore-components-e2e test runs, ensuring validation-related regressions are caught by the Blazor E2E suite.
Changes:
- Add
src/Validation/*topr.paths.includefor the public Components E2E pipeline. - Add
src/Validation/*topr.paths.includefor the internal Components E2E pipeline.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .azure/pipelines/components-e2e-tests.yml | Extends PR path filters to run Components E2E when src/Validation changes. |
| .azure/pipelines/components-e2e-tests-internal.yml | Mirrors the same src/Validation PR path filter addition for the internal pipeline. |
Member
Author
|
@javiercn @Youssef1313 Do you think it is worth it to make CI longer for MEV changes? Alternatively, we could add a simple Blazor app for E2E testing under |
lewing
approved these changes
Jul 9, 2026
Youssef1313
approved these changes
Jul 9, 2026
oroztocil
enabled auto-merge (squash)
July 9, 2026 15:06
wtgodbe
approved these changes
Jul 9, 2026
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blazor form validation depends on
src/Validation(Microsoft.Extensions.Validation): theDataAnnotationsValidatorroutes through MEV'sIValidatableTypeInfowhen a model is registered, and the Blazor E2E suite exercises this viaAddValidationIntegrationTest.However, the list of path triggers for the
aspnetcore-components-e2epipeline did not includesrc/Validation, so PRs that change only the validation source generator or library never ran the Blazor E2E tests. This let #67636 merge a MEV generator change that brokeAddValidationIntegrationTest.FormWithNestedValidation_Workswithout any signal on the PR.This adds
src/Validation/*to thepr.paths.includefilter of both the public and internal components-e2e pipeline definitions, so validation changes now trigger the Blazor E2E tests that depend on MEV.Related to #67699