This repository was archived by the owner on Jan 11, 2024. It is now read-only.
Fix dumplinghelper to not log 'error format' - #1909
Merged
Merged
Conversation
Author
|
Merging to try to get build going. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous fix solved the problem of HTTPError.reason not always being present by using
str()instead. This caused another problem: to MSBuild,Dumpling cannot be installed due to : HTTP error 403: Site Disabledlooks like standard error format, so absent other instructions, it fails the build.Fix that by removing any colon.