This repository was archived by the owner on Jan 11, 2024. It is now read-only.
Use the built tasks to update dotnet/versions - #1935
Merged
Conversation
This allows us to use the TLS 1.2 UpdatePublishedVersions fix without upgrading the BuildTools toolset version.
MattGal
reviewed
Feb 28, 2018
|
|
||
| TODO: Remove this workaround once BuildTools uses a new BuildTools version: https://github.com/dotnet/buildtools/issues/1934 | ||
| --> | ||
| <UsingTask TaskName="UpdatePublishedVersions" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
Author
|
Didn't work in the official build: https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1427170. Looking into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to use the TLS 1.2 UpdatePublishedVersions fix without upgrading the BuildTools toolset version.
Doing this properly (updating the BuildTools toolset version) is tracked by #1934. I hit enough obstacles that I don't think it's in scope for First Responder.
https://github.com/dotnet/core-eng/issues/2734: Unblocks auto-update of
masterBuildTools builds to subscribing repos. This change will need to be ported torelease/2.1, at least.