Skip to content
This repository was archived by the owner on Jan 11, 2024. It is now read-only.

Use AssemblyResolver during PushToBlobFeed - #1943

Merged
dagood merged 1 commit into
dotnet:masterfrom
dagood:fix-nuget-dep
Mar 6, 2018
Merged

Use AssemblyResolver during PushToBlobFeed#1943
dagood merged 1 commit into
dotnet:masterfrom
dagood:fix-nuget-dep

Conversation

@dagood

@dagood dagood commented Mar 6, 2018

Copy link
Copy Markdown
Member

Fixes failure to resolve NuGet.Common, Version=4.3.0.5 from Sleet dependency.

https://github.com/dotnet/core-eng/issues/2828

Fixes failure to resolve NuGet.Common, Version=4.3.0.5 from Sleet dependency.
@dagood

dagood commented Mar 6, 2018

Copy link
Copy Markdown
Member Author

Filed #1944 to track using a shared BuildTask.Desktop.cs rather than implementing the static constructor specifically for PushToBlobFeed.

@dagood
dagood requested a review from jcagme March 6, 2018 19:52

@jcagme jcagme left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagood
dagood merged commit 1830f2d into dotnet:master Mar 6, 2018
@dagood
dagood deleted the fix-nuget-dep branch March 6, 2018 20:03
{
public partial class PushToBlobFeed
{
static PushToBlobFeed()

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@weshaggard weshaggard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants