Skip to content
This repository was archived by the owner on Jan 11, 2024. It is now read-only.

Extract async task to avoid swallowing of TaskCanceledException - #1950

Merged
1 commit merged into
masterfrom
unknown repository
Mar 9, 2018
Merged

Extract async task to avoid swallowing of TaskCanceledException#1950
1 commit merged into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Mar 9, 2018

Copy link
Copy Markdown

Extract async task to avoid swallowing of TaskCanceledException from HttpClient.GetStreamAsync() in DownloadFilesFromUrl

@dagood dagood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ghost

ghost commented Mar 9, 2018

Copy link
Copy Markdown
Author

While I get my permissions propagated to assign reviewers, CC @jcagme since he has context for the issue.

@ghost
ghost requested a review from jcagme March 9, 2018 20:15

@jcagme jcagme left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
ghost merged commit 1491851 into dotnet:master Mar 9, 2018
@ghost
ghost deleted the fix-infinite-downloadFilesFromUrl branch March 9, 2018 20:29
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants