This repository was archived by the owner on Jan 11, 2024. It is now read-only.
Adding an MSBuildSdkUpdater to the BaseDependenciesTask - #2117
Merged
Conversation
Member
Author
tannergooding
commented
Aug 7, 2018
| } | ||
| else if (!string.IsNullOrEmpty(msbuildSdkName)) | ||
| { | ||
| updater.Regex = CreateMSBuildSdkUpdateRegex(Regex.Escape(msbuildSdkName), nameof(msbuildSdkName)); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dagood
reviewed
Aug 7, 2018
| } | ||
| else | ||
| { | ||
| throw new ArgumentException( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dagood
reviewed
Aug 7, 2018
| new Regex($@"<{elementName}>(?<{contentGroupName}>.*)</{elementName}>"); | ||
|
|
||
| protected Regex CreateMSBuildSdkUpdateRegex(string msbuildSdkName, string contentGroupName) => | ||
| new Regex($@"""{msbuildSdkName}"": ""(?<{contentGroupName}>.*)"""); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow the the ILProj SDK to be automatically updated. See dotnet/corefx#31512 for more details.